Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(consensus): minor refactor for how the log and db dirs are created and passed #880

Merged

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 19, 2024

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review September 19, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from 665bf3a to 2d3e7ed Compare September 19, 2024 07:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 7012d10 to cf3898a Compare September 19, 2024 07:33
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 8.31%. Comparing base (b0cfe82) to head (512b6da).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
...encing/papyrus_consensus/src/bin/run_simulation.rs 0.00% 24 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (512b6da). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (512b6da)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #880       +/-   ##
==========================================
- Coverage   74.18%   8.31%   -65.87%     
==========================================
  Files         359      71      -288     
  Lines       36240    8702    -27538     
  Branches    36240    8702    -27538     
==========================================
- Hits        26886     724    -26162     
- Misses       7220    7942      +722     
+ Partials     2134      36     -2098     
Flag Coverage Δ
8.31% <0.00%> (-65.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from cf3898a to 9d47c53 Compare September 19, 2024 08:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from 7d5e08b to 0dbb3fd Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 9d47c53 to 9816a04 Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from c76dbad to d39e534 Compare September 19, 2024 10:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 9816a04 to 15abe6b Compare September 19, 2024 10:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 15abe6b to 857db2b Compare September 19, 2024 11:10
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 4b5df08 to a36a76d Compare September 19, 2024 11:42
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_consensus branch 2 times, most recently from 333f99a to 8bcad6e Compare September 19, 2024 12:07
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from a36a76d to 4fcb551 Compare September 19, 2024 12:07
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 4fcb551 to 3f6510a Compare September 19, 2024 12:40
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 3f6510a to 42ae721 Compare September 22, 2024 07:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 42ae721 to 5ec798b Compare September 22, 2024 08:01
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 5ec798b to 83b6da3 Compare September 22, 2024 08:02
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 83b6da3 to 780cfe1 Compare September 22, 2024 08:04
@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/run_consensus to graphite-base/880 September 22, 2024 12:13
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 780cfe1 to aa0b714 Compare September 22, 2024 12:14
@matan-starkware matan-starkware changed the base branch from graphite-base/880 to main September 22, 2024 12:14
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from aa0b714 to 258a4c0 Compare September 22, 2024 12:14
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/run_simulation_setup_artifact_dirs branch from 258a4c0 to 512b6da Compare September 24, 2024 09:09
Copy link
Contributor Author

matan-starkware commented Sep 24, 2024

Merge activity

@matan-starkware matan-starkware merged commit 69aaac8 into main Sep 24, 2024
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants