Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): introduce PapyrusTaskHandles to hold task overrides #872

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (dc78be5) to head (26615c9).

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 65.00% 12 Missing and 9 partials ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##           matan/consensus/m5/spawn_monitoring_server     #872      +/-   ##
==============================================================================
- Coverage                                       74.31%   74.28%   -0.03%     
==============================================================================
  Files                                             357      357              
  Lines                                           36263    36280      +17     
  Branches                                        36263    36280      +17     
==============================================================================
+ Hits                                            26948    26952       +4     
- Misses                                           7182     7190       +8     
- Partials                                         2133     2138       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 68b900e to 303a331 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 651c1f9 to 2539e07 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 303a331 to d68cd9d Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 2539e07 to b4a3ebd Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from d68cd9d to df38d10 Compare September 19, 2024 07:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from b4a3ebd to 894e7a9 Compare September 19, 2024 07:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from df38d10 to 793e805 Compare September 19, 2024 07:32
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 894e7a9 to 6fc5a1a Compare September 19, 2024 07:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch 2 times, most recently from 70a3e04 to 9de2827 Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch 2 times, most recently from 2908ed0 to 691dfc0 Compare September 19, 2024 08:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 9de2827 to 4d56284 Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 691dfc0 to b6c3ec8 Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch 2 times, most recently from 25390ef to dc78be5 Compare September 19, 2024 10:34
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from b6c3ec8 to 26615c9 Compare September 19, 2024 10:34
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware deleted the branch matan/consensus/m5/spawn_monitoring_server September 19, 2024 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants