Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): network channel creation is done by users #863

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This replaces the register function with creating the network manager resource that
any task can user.


This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 44 lines in your changes missing coverage. Please review.

Project coverage is 74.46%. Comparing base (ac56ada) to head (96f38ba).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 18.51% 39 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   74.47%   74.46%   -0.01%     
==========================================
  Files         368      368              
  Lines       38590    38589       -1     
  Branches    38590    38589       -1     
==========================================
- Hits        28741    28737       -4     
- Misses       7519     7521       +2     
- Partials     2330     2331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_p2p_sync_server branch from 3be1b4a to d23d8ec Compare September 18, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from 5cbadaf to 6aeb106 Compare September 18, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_p2p_sync_server branch from d23d8ec to 78b1985 Compare September 18, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from 6aeb106 to f1c0ba5 Compare September 18, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_p2p_sync_server branch 2 times, most recently from 875d08a to 9d6e8be Compare September 18, 2024 14:04
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch 2 times, most recently from 0a648c0 to aab1d3a Compare September 18, 2024 14:04
@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/build_p2p_sync_server to graphite-base/863 September 18, 2024 14:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from aab1d3a to aa1c819 Compare September 18, 2024 14:25
@matan-starkware matan-starkware changed the base branch from graphite-base/863 to main September 18, 2024 14:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from aa1c819 to 9fd3e44 Compare September 18, 2024 14:26
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

This replaces the register function with creating the network manager resource that
any task can user.
Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware merged commit 4e3a355 into main Sep 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants