Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): split run from main, as it will be used by many binaries #873

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

Also moved build_network_manager function.


This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (bdb18d7) to head (7c9e727).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 18.51% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   74.30%   74.27%   -0.03%     
==========================================
  Files         357      357              
  Lines       36275    36285      +10     
  Branches    36275    36285      +10     
==========================================
- Hits        26953    26951       -2     
- Misses       7184     7195      +11     
- Partials     2138     2139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 651c1f9 to 2539e07 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 2539e07 to b4a3ebd Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from b4a3ebd to 894e7a9 Compare September 19, 2024 07:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 894e7a9 to 6fc5a1a Compare September 19, 2024 07:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 6fc5a1a to 2908ed0 Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 2908ed0 to 691dfc0 Compare September 19, 2024 08:59
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_task_handles branch from 691dfc0 to b6c3ec8 Compare September 19, 2024 10:18
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matan-starkware)


crates/papyrus_node/src/main.rs line 523 at r1 (raw file):

}

pub async fn run(

Where is the call to run?

Code quote:

pub async fn run(

Copy link
Contributor Author

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dan-starkware)


crates/papyrus_node/src/main.rs line 523 at r1 (raw file):

Previously, dan-starkware wrote…

Where is the call to run?

Whoops, that was supposed to be in fn main. It's correct in the next PR so must have messed up when splitting the diffs.

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/papyrus_task_handles to graphite-base/873 September 19, 2024 11:40
@matan-starkware matan-starkware changed the base branch from graphite-base/873 to main September 19, 2024 11:41
Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware merged commit d450daf into main Sep 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants