-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(node): split run from main, as it will be used by many binaries #873
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matan-starkware and the rest of your teammates on Graphite |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 74.30% 74.27% -0.03%
==========================================
Files 357 357
Lines 36275 36285 +10
Branches 36275 36285 +10
==========================================
- Hits 26953 26951 -2
- Misses 7184 7195 +11
- Partials 2138 2139 +1 ☔ View full report in Codecov by Sentry. |
651c1f9
to
2539e07
Compare
8e96e3e
to
ab46319
Compare
2539e07
to
b4a3ebd
Compare
ab46319
to
c9fc38d
Compare
b4a3ebd
to
894e7a9
Compare
c9fc38d
to
2d6c786
Compare
894e7a9
to
6fc5a1a
Compare
2d6c786
to
864ca2b
Compare
6fc5a1a
to
2908ed0
Compare
864ca2b
to
e07ecdc
Compare
2908ed0
to
691dfc0
Compare
e07ecdc
to
9384dd9
Compare
691dfc0
to
b6c3ec8
Compare
9384dd9
to
5a826fd
Compare
b6c3ec8
to
26615c9
Compare
5a826fd
to
fe80c0f
Compare
26615c9
to
af3d5d3
Compare
fe80c0f
to
0fbc272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matan-starkware)
crates/papyrus_node/src/main.rs
line 523 at r1 (raw file):
} pub async fn run(
Where is the call to run?
Code quote:
pub async fn run(
0fbc272
to
c097f50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
crates/papyrus_node/src/main.rs
line 523 at r1 (raw file):
Previously, dan-starkware wrote…
Where is the call to run?
Whoops, that was supposed to be in fn main
. It's correct in the next PR so must have messed up when splitting the diffs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
af3d5d3
to
bdb18d7
Compare
c097f50
to
0ae8966
Compare
Also moved build_network_manager function.
0ae8966
to
7c9e727
Compare
Merge activity
|
Also moved build_network_manager function.
This change is