Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): introduce PapyrusTaskHandles to hold task overrides #885

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 19, 2024

This change is Reviewable

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (42bc7ab) to head (af3d5d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 65.00% 12 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
- Coverage   74.32%   74.28%   -0.04%     
==========================================
  Files         357      357              
  Lines       36258    36280      +22     
  Branches    36258    36280      +22     
==========================================
+ Hits        26947    26951       +4     
- Misses       7177     7190      +13     
- Partials     2134     2139       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware merged commit bdb18d7 into main Sep 19, 2024
24 of 44 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants