Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): refactor how monitoring server is spawned #871

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (ca450a3) to head (dc78be5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 77.77% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   74.32%   74.31%   -0.02%     
==========================================
  Files         357      357              
  Lines       36250    36263      +13     
  Branches    36250    36263      +13     
==========================================
+ Hits        26943    26948       +5     
- Misses       7175     7182       +7     
- Partials     2132     2133       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from bf92ac0 to 5539129 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 68b900e to 303a331 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 5539129 to d79d5d5 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 303a331 to d68cd9d Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from d79d5d5 to 721ac79 Compare September 19, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from d68cd9d to df38d10 Compare September 19, 2024 07:27
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 721ac79 to d144746 Compare September 19, 2024 07:32
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from df38d10 to 793e805 Compare September 19, 2024 07:32
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch 2 times, most recently from be154ce to 7940de7 Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch 2 times, most recently from 70a3e04 to 9de2827 Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 7940de7 to 98a4868 Compare September 19, 2024 10:18
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 9de2827 to 4d56284 Compare September 19, 2024 10:18
@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/spawn_task_uniform_type to graphite-base/871 September 19, 2024 10:33
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 4d56284 to 25390ef Compare September 19, 2024 10:33
@matan-starkware matan-starkware changed the base branch from graphite-base/871 to main September 19, 2024 10:34
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_monitoring_server branch from 25390ef to dc78be5 Compare September 19, 2024 10:34
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware merged commit 42bc7ab into main Sep 19, 2024
24 checks passed
@matan-starkware matan-starkware deleted the matan/consensus/m5/spawn_monitoring_server branch September 19, 2024 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants