Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): move building the sync client to its own function #861

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 59.72222% with 29 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (fa8057c) to head (044d791).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 59.72% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
+ Coverage   74.42%   74.49%   +0.07%     
==========================================
  Files         366      366              
  Lines       38550    38555       +5     
  Branches    38550    38555       +5     
==========================================
+ Hits        28690    28723      +33     
+ Misses       7534     7508      -26     
+ Partials     2326     2324       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/storage_metrics_handle_builder to graphite-base/861 September 18, 2024 13:38
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_sync_client branch 2 times, most recently from 690d559 to 6bb5778 Compare September 18, 2024 13:39
@matan-starkware matan-starkware changed the base branch from graphite-base/861 to main September 18, 2024 13:39
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_sync_client branch from 6bb5778 to 044d791 Compare September 18, 2024 13:39
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Contributor Author

matan-starkware commented Sep 18, 2024

Merge activity

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants