Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): create papyrus resources for generating top level tasks #865

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (f725bc7) to head (31f2e51).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 89.58% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   74.38%   74.38%   -0.01%     
==========================================
  Files         368      368              
  Lines       38476    38496      +20     
  Branches    38476    38496      +20     
==========================================
+ Hits        28622    28634      +12     
- Misses       7528     7535       +7     
- Partials     2326     2327       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from 9fd3e44 to aa1c819 Compare September 18, 2024 16:53
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_resources branch from 8f59b87 to d4b6124 Compare September 18, 2024 16:53
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/build_network_manager branch from aa1c819 to 96f38ba Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_resources branch from d4b6124 to 2cbcc64 Compare September 19, 2024 05:51
@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/build_network_manager to graphite-base/865 September 19, 2024 07:24
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_resources branch from 2cbcc64 to e97d535 Compare September 19, 2024 07:25
@matan-starkware matan-starkware changed the base branch from graphite-base/865 to main September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_resources branch 2 times, most recently from 1f92d63 to dcef330 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/papyrus_resources branch from dcef330 to 31f2e51 Compare September 19, 2024 07:32
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware merged commit 87ae7b8 into main Sep 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants