Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): convert storage metrics handle to the desired task type #860

Merged

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review September 18, 2024 12:48
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/storage_metrics_handle_builder branch from 6495646 to 10e5d20 Compare September 18, 2024 13:17
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.44%. Comparing base (8aa893b) to head (10e5d20).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   74.44%   74.44%   -0.01%     
==========================================
  Files         364      366       +2     
  Lines       38395    38555     +160     
  Branches    38395    38555     +160     
==========================================
+ Hits        28583    28702     +119     
- Misses       7493     7527      +34     
- Partials     2319     2326       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

matan-starkware commented Sep 18, 2024

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants