Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): spawned tasks should all return anyhow result #870

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Sep 18, 2024

This fairly generic return type should allow for flexibility with test overrides.


This change is Reviewable

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 18.91892% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (c36ed0d) to head (98a4868).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/papyrus_node/src/main.rs 18.91% 27 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   74.33%   74.31%   -0.02%     
==========================================
  Files         357      357              
  Lines       36240    36255      +15     
  Branches    36240    36255      +15     
==========================================
+ Hits        26940    26944       +4     
- Misses       7169     7179      +10     
- Partials     2131     2132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch from 82076a9 to 56b34c8 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from bf92ac0 to 5539129 Compare September 19, 2024 05:51
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch from 56b34c8 to a2168a7 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 5539129 to d79d5d5 Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch from a2168a7 to 91cf2fd Compare September 19, 2024 07:25
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from d79d5d5 to 721ac79 Compare September 19, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch from 91cf2fd to c5148bb Compare September 19, 2024 07:32
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 721ac79 to d144746 Compare September 19, 2024 07:32
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch 2 times, most recently from c7e2865 to 94b189c Compare September 19, 2024 08:57
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from d144746 to be154ce Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/clippy_suggestions branch from 94b189c to 4d0cb89 Compare September 19, 2024 08:58
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from be154ce to 7940de7 Compare September 19, 2024 08:58
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Contributor Author

matan-starkware commented Sep 19, 2024

Merge activity

@matan-starkware matan-starkware changed the base branch from matan/consensus/m5/clippy_suggestions to graphite-base/870 September 19, 2024 10:17
@matan-starkware matan-starkware changed the base branch from graphite-base/870 to main September 19, 2024 10:17
This fairly generic return type should allow for flexibility with test overrides.
@matan-starkware matan-starkware force-pushed the matan/consensus/m5/spawn_task_uniform_type branch from 7940de7 to 98a4868 Compare September 19, 2024 10:18
@matan-starkware matan-starkware merged commit ca450a3 into main Sep 19, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants