-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(node): spawned tasks should all return anyhow result #870
refactor(node): spawned tasks should all return anyhow result #870
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
- Coverage 74.33% 74.31% -0.02%
==========================================
Files 357 357
Lines 36240 36255 +15
Branches 36240 36255 +15
==========================================
+ Hits 26940 26944 +4
- Misses 7169 7179 +10
- Partials 2131 2132 +1 ☔ View full report in Codecov by Sentry. |
82076a9
to
56b34c8
Compare
bf92ac0
to
5539129
Compare
56b34c8
to
a2168a7
Compare
5539129
to
d79d5d5
Compare
a2168a7
to
91cf2fd
Compare
d79d5d5
to
721ac79
Compare
91cf2fd
to
c5148bb
Compare
721ac79
to
d144746
Compare
c7e2865
to
94b189c
Compare
d144746
to
be154ce
Compare
94b189c
to
4d0cb89
Compare
be154ce
to
7940de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
Merge activity
|
This fairly generic return type should allow for flexibility with test overrides.
7940de7
to
98a4868
Compare
This fairly generic return type should allow for flexibility with test overrides.
This change is