Separate componenet and air trace writers.

[alonh5]

This change is 

[alonh5]

• Extract constraint code into functions. #644 : 2 dependent PRs (#646 , #654 )
• Use SecureField in interaction. #642
• Modify mask_points for interaction. #639
• Modify trace_log_degree_bounds for interaction. #638
• Add wide fib lookup constraint. #637
• Add interaction to proof. #636
• Separate componenet and air trace writers. #651 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (bedd93e) to head (54c6c5b).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #651      +/-   ##
==========================================
+ Coverage   92.24%   92.49%   +0.25%     
==========================================
  Files          69       69              
  Lines        9050     9025      -25     
  Branches     9050     9025      -25     
==========================================
  Hits         8348     8348              
+ Misses        629      604      -25     
  Partials       73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5 and @ohad-starkware)

---

crates/prover/src/core/air/mod.rs line 29 at r1 (raw file):

pub trait AirTraceVerifier {
    fn interaction_elements(&self, channel: &mut Blake2sChannel) -> InteractionElements;
}

What is this trait?
Should this function be a part of the regular Air trait?

Code quote:

pub trait AirTraceVerifier {
    fn interaction_elements(&self, channel: &mut Blake2sChannel) -> InteractionElements;
}

---

crates/prover/src/core/air/mod.rs line 80 at r1 (raw file):

}

// TODO(AlonH): Rethink this trait.

I think you can remove that

Code quote:

// TODO(AlonH): Rethink this trait.

[ohad-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/prover/src/core/air/mod.rs line 38 at r1 (raw file):

    ) -> ComponentVec<CircleEvaluation<B, BaseField, BitReversedOrder>>;

    fn to_air_prover(&self) -> &dyn AirProver<B>;

why dyn here? wouldn't it be a static type in every implementation?

[ohad-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/prover/src/core/air/mod.rs line 38 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

why dyn here? wouldn't it be a static type in every implementation?

nevermind you changed it later

[ohad-starkware]

other than the trait seperation (every Air is an AirVerifier)

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

[alonh5]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/core/air/mod.rs line 29 at r1 (raw file):

Previously, shaharsamocha7 wrote…

What is this trait?
Should this function be a part of the regular Air trait?

Then AirTraceWriter would also have to be an Air and therefore implement components, which it can't. This is part of the separation we needed.

---

crates/prover/src/core/air/mod.rs line 80 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I think you can remove that

Done.

[ohad-starkware]

Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

[shaharsamocha7]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)