Remove interaction_elements_ids from Component trait. #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #695 +/- ##
==========================================
+ Coverage 90.13% 90.18% +0.04%
==========================================
Files 76 76
Lines 10059 10054 -5
Branches 10059 10054 -5
==========================================
Hits 9067 9067
+ Misses 910 905 -5
Partials 82 82 ☔ View full report in Codecov by Sentry. |
shaharsamocha7
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alonh5)
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
1e85cf1
to
239af41
Compare
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
8d6d5dc
to
5213747
Compare
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
239af41
to
70c76e0
Compare
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
5213747
to
db449ac
Compare
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
70c76e0
to
640151c
Compare
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
db449ac
to
02de561
Compare
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
640151c
to
b9ac5d3
Compare
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
02de561
to
57ff0b9
Compare
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
b9ac5d3
to
a12c233
Compare
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
57ff0b9
to
5145f94
Compare
alonh5
force-pushed
the
06-24-implement_trace_generator_for_fibonacci
branch
from
a12c233
to
9b98357
Compare
alonh5
changed the base branch from
06-24-implement_trace_generator_for_fibonacci
to
dev
alonh5
force-pushed
the
07-03-remove_interaction_elements_ids_from_component_trait
branch
from
5145f94
to
c20e41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is