Implement from_qm31_array for QM31.

[alonh5]

This change is 

[alonh5]

• Refactor constraint evaluation. #696
• Implement from_qm31_array for QM31. #679 👈
• Create phase number constants. #669 : 2 other dependent PRs (#671 , #677 )
• Add final lookup constraint. #667
• Add lookup final boundary constraints. #664
• Separate constraint point evaluation to functions. #662
• Add wide fib lookup step constraint. #646
• Extract constraint code into functions. #644 : 1 other dependent PR (#654 )
• Use SecureField in interaction. #642
• Modify mask_points for interaction. #639
• Modify trace_log_degree_bounds for interaction. #638
• Add wide fib lookup constraint. #637
• Add interaction to proof. #636
• Separate componenet and air trace writers. #651
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (30ad352) to head (5c8c89d).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #679   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files          75       75           
  Lines       10013    10013           
  Branches    10013    10013           
=======================================
  Hits         9040     9040           
  Misses        892      892           
  Partials       81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/prover/src/core/fields/qm31.rs line 47 at r1 (raw file):

    /// Returns the combined value, given the values of its composing base field polynomials at that
    /// point.
    pub fn from_qm31_array(evals: [Self; SECURE_EXTENSION_DEGREE]) -> Self {

Actually I don't like this name.
from_array sound as it just trivially pack them, but this is doing something else

WDYT?

Code quote:

pub fn from_qm31_array

[alonh5]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/core/fields/qm31.rs line 47 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Actually I don't like this name.
from_array sound as it just trivially pack them, but this is doing something else

WDYT?

Changed the name, wdyt?

[shaharsamocha7]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/prover/src/core/fields/qm31.rs line 47 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Changed the name, wdyt?

maybe from_partial_evals

[shaharsamocha7]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

[shaharsamocha7]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

[shaharsamocha7]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[alonh5]

Merge activity

• Jul 8, 4:33 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
• Jul 8, 4:45 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 8, 4:48 AM EDT: @alonh5 merged this pull request with Graphite.