Implement trace generator for fibonacci.

[alonh5]

This change is 

[alonh5]

• Remove interaction_elements_ids from Component trait. #695
• Implement trace generator for fibonacci. #674 👈
• Merge trace writer and trace generator. #672 : 1 other dependent PR (#675 )
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.13%. Comparing base (4231088) to head (9b98357).

Files	Patch %	Lines
crates/prover/src/trace_generation/mod.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #674      +/-   ##
==========================================
+ Coverage   90.09%   90.13%   +0.04%     
==========================================
  Files          75       76       +1     
  Lines       10053    10059       +6     
  Branches    10053    10059       +6     
==========================================
+ Hits         9057     9067      +10     
+ Misses        915      910       -5     
- Partials       81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ohad-starkware]

Reviewed 9 of 12 files at r3, all commit messages.
Reviewable status: 9 of 12 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @shaharsamocha7)

---

crates/prover/src/examples/fibonacci/air.rs line 51 at r3 (raw file):

            .registry
            .get_generator::<FibonacciTraceGenerator>("fibonacci");
        // TODO(AlonH): Take instead of clone.

left by accident?

---

crates/prover/src/examples/fibonacci/component.rs line 137 at r3 (raw file):

#[derive(Clone)]
pub struct FibonacciTraceGenerator {

Option

---

crates/prover/src/examples/fibonacci/component.rs line 172 at r3 (raw file):

        registry: &mut ComponentGenerationRegistry,
    ) -> ColumnVec<CircleEvaluation<CpuBackend, BaseField, BitReversedOrder>> {
        let component = registry.get_generator_mut::<Self>(component_id);

Suggestion:

trace_generator

---

crates/prover/src/examples/wide_fibonacci/simd.rs line 53 at r3 (raw file):

// TODO(AlonH): Remove this once the Cpu and Simd implementations are aligned.
#[derive(Clone)]

The way to get rid of this struct is to have a separate WideFibSimdTraceGenerator and implementing TraceGenerator

---

crates/prover/src/trace_generation/mod.rs line 54 at r3 (raw file):

    fn write_trace(&mut self) -> Vec<CircleEvaluation<B, BaseField, BitReversedOrder>> {
        vec![]

temporary, right?

[alonh5]

Reviewable status: 9 of 12 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware and @shaharsamocha7)

---

crates/prover/src/examples/fibonacci/air.rs line 51 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

left by accident?

Yes, thanks.

---

crates/prover/src/examples/fibonacci/component.rs line 137 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

Option

WDYM?

---

crates/prover/src/examples/wide_fibonacci/simd.rs line 53 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

The way to get rid of this struct is to have a separate WideFibSimdTraceGenerator and implementing TraceGenerator

We will still need this struct then, it just own't implement TraceGenerator.

---

crates/prover/src/trace_generation/mod.rs line 54 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

temporary, right?

Yes, added a TODO to remove it.

[ohad-starkware]

Reviewed 1 of 12 files at r3, 2 of 3 files at r4.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

---

crates/prover/src/examples/fibonacci/component.rs line 139 at r4 (raw file):

pub struct FibonacciTraceGenerator {
    log_size: Option<u32>,
    claim: Option<BaseField>,

Suggestion:

input: Option<FibonacciInput>

[alonh5]

Reviewable status: 10 of 12 files reviewed, all discussions resolved (waiting on @ohad-starkware and @shaharsamocha7)

---

crates/prover/src/examples/fibonacci/component.rs line 139 at r4 (raw file):

pub struct FibonacciTraceGenerator {
    log_size: Option<u32>,
    claim: Option<BaseField>,

Done.

[ohad-starkware]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

[alonh5]

Merge activity

• Jul 8, 7:18 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
• Jul 8, 7:21 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 8, 7:24 AM EDT: @alonh5 merged this pull request with Graphite.