Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate constraint point evaluation to functions. #662

Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jun 13, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (ae26ec4) to head (80e544d).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           05-28-add_wide_fib_lookup_step_constraint     #662   +/-   ##
==========================================================================
  Coverage                                      90.03%   90.03%           
==========================================================================
  Files                                             75       75           
  Lines                                           9730     9730           
  Branches                                        9730     9730           
==========================================================================
  Hits                                            8760     8760           
  Misses                                           889      889           
  Partials                                          81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 4ab22fc to 48a7e63 Compare June 16, 2024 09:00
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 7fde27d to 9213842 Compare June 16, 2024 09:00
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 48a7e63 to cf7a8a3 Compare June 18, 2024 07:03
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 9213842 to 742429f Compare June 18, 2024 07:03
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from cf7a8a3 to db43a12 Compare June 18, 2024 07:23
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 742429f to 44f0659 Compare June 18, 2024 07:23
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from db43a12 to 3ced4d2 Compare June 20, 2024 11:29
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 44f0659 to bf7c591 Compare June 20, 2024 11:29
@alonh5 alonh5 mentioned this pull request Jun 20, 2024
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 3ced4d2 to 09b5483 Compare June 23, 2024 09:18
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from bf7c591 to 07495e7 Compare June 23, 2024 09:18
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 09b5483 to b601adb Compare June 23, 2024 09:23
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 07495e7 to d152bfc Compare June 23, 2024 09:23
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from b601adb to 2264b29 Compare June 23, 2024 10:20
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from d152bfc to 3790bc0 Compare June 23, 2024 10:20
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 2264b29 to ae7fc7b Compare June 23, 2024 10:58
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 3790bc0 to 2dbaffe Compare June 23, 2024 10:58
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from ae7fc7b to 28a99cc Compare June 23, 2024 13:02
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 2dbaffe to 0419240 Compare June 23, 2024 13:02
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 28a99cc to d615ec9 Compare June 23, 2024 13:20
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 0419240 to 8a511df Compare June 23, 2024 13:20
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from d615ec9 to 6c72919 Compare June 23, 2024 13:35
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 8a511df to 55ada84 Compare June 23, 2024 13:35
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 6c72919 to fe6bf5b Compare June 24, 2024 10:02
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 55ada84 to 5238ab3 Compare June 24, 2024 10:02
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from fe6bf5b to 4d92879 Compare June 26, 2024 10:23
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 5238ab3 to 89d32d8 Compare June 26, 2024 10:23
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 4d92879 to 481218e Compare June 27, 2024 10:56
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 89d32d8 to d34c480 Compare June 27, 2024 10:56
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 481218e to 4dfe8ff Compare June 30, 2024 08:32
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from d34c480 to 07062b0 Compare June 30, 2024 08:32
@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 4dfe8ff to 3495fde Compare July 1, 2024 10:47
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 07062b0 to 75477b2 Compare July 1, 2024 10:47
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 force-pushed the 05-28-add_wide_fib_lookup_step_constraint branch from 3495fde to ae26ec4 Compare July 2, 2024 07:52
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 75477b2 to 80e544d Compare July 2, 2024 08:59
Copy link
Contributor Author

alonh5 commented Jul 2, 2024

Merge activity

  • Jul 2, 8:47 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
  • Jul 2, 8:49 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 2, 8:51 AM EDT: @alonh5 merged this pull request with Graphite.

@alonh5 alonh5 changed the base branch from 05-28-add_wide_fib_lookup_step_constraint to dev July 2, 2024 12:47
@alonh5 alonh5 force-pushed the 06-13-separate_constraint_point_evaluation_to_functions branch from 80e544d to b9ced65 Compare July 2, 2024 12:48
@alonh5 alonh5 merged commit ffeb96a into dev Jul 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants