Verify lookups. #675
Merged
Verify lookups. #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #675 +/- ##
==========================================
- Coverage 90.52% 90.49% -0.04%
==========================================
Files 76 76
Lines 10165 10169 +4
Branches 10165 10169 +4
==========================================
Hits 9202 9202
- Misses 881 884 +3
- Partials 82 83 +1 ☔ View full report in Codecov by Sentry. |
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
f3e308f
to
c629f7d
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
1dcb284
to
15babd6
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
c629f7d
to
f39cfea
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
15babd6
to
349b2af
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
2 times, most recently
from
3aa5079
to
673b1b3
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
2 times, most recently
from
8629004
to
12ad169
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
673b1b3
to
50be746
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
2 times, most recently
from
03d31a3
to
ad99893
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
50be746
to
ca2c907
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
ad99893
to
b3345f3
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
ca2c907
to
2f0aac7
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
2 times, most recently
from
40d43f0
to
e8048c4
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
2f0aac7
to
0d56bd7
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
e8048c4
to
4604866
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
0d56bd7
to
93dd654
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
4604866
to
b580482
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
93dd654
to
f8d5799
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
b580482
to
db5ea36
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
f8d5799
to
9bb7d3a
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
db5ea36
to
c516408
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
9bb7d3a
to
4e36e51
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
c516408
to
d282583
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
4e36e51
to
ddf0fe6
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
d282583
to
ea323fa
Compare
alonh5
force-pushed
the
06-23-merge_trace_writer_and_trace_generator
branch
from
ddf0fe6
to
2ce2998
Compare
alonh5
force-pushed
the
06-24-verify_lookups
branch
2 times, most recently
from
1468ea2
to
2d03eb2
Compare
alonh5
changed the base branch from
06-23-merge_trace_writer_and_trace_generator
to
dev
alonh5
force-pushed
the
06-24-verify_lookups
branch
2 times, most recently
from
f759f41
to
555732f
Compare
There was a problem hiding this comment.
Implement only on Air, not on components
Reviewed all commit messages.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @andrewmilson and @shaharsamocha7)
alonh5
force-pushed
the
06-24-verify_lookups
branch
from
555732f
to
d15ad54
Compare
alonh5
commented
Jul 11, 2024
There was a problem hiding this comment.
Done.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @andrewmilson and @shaharsamocha7)
spapinistarkware
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Reviewed 8 of 9 files at r4, all commit messages.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @andrewmilson and @shaharsamocha7)
alonh5
commented
Jul 11, 2024
There was a problem hiding this comment.
Reviewed 1 of 9 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewmilson and @shaharsamocha7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is