-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch inverse lookup column denominators. #677
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #677 +/- ##
=======================================
Coverage 90.67% 90.67%
=======================================
Files 76 76
Lines 10117 10117
Branches 10117 10117
=======================================
Hits 9174 9174
Misses 861 861
Partials 82 82 ☔ View full report in Codecov by Sentry. |
6cf38e5
to
64c7e41
Compare
f30431b
to
88fc2d1
Compare
64c7e41
to
c683c25
Compare
88fc2d1
to
a7bafa9
Compare
5602db4
to
9d0bec0
Compare
a7bafa9
to
0b876a7
Compare
9d0bec0
to
8257e32
Compare
0b876a7
to
2bf0cca
Compare
fc63560
to
47fb3f1
Compare
2bf0cca
to
ab1710e
Compare
ee8f106
to
a0ba183
Compare
ab1710e
to
f1f50e2
Compare
a0ba183
to
89129d0
Compare
f1f50e2
to
22bfdd3
Compare
89129d0
to
5839c99
Compare
22bfdd3
to
a9e266b
Compare
5839c99
to
69c7e59
Compare
a9e266b
to
266178b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @shaharsamocha7)
crates/prover/src/examples/wide_fibonacci/simd.rs
line 164 at r2 (raw file):
} // TODO(AlonH): Implement.
its still not implemented
c772159
to
380101b
Compare
380101b
to
4868f67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
crates/prover/src/examples/wide_fibonacci/simd.rs
line 164 at r2 (raw file):
Previously, ohad-starkware (Ohad) wrote…
its still not implemented
Right but I don't think the todo is necessary, there's a bunch of things still not implemented.
Previously, alonh5 (Alon Haramati) wrote…
agreed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
This change is