Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch inverse lookup column denominators. #677

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jun 25, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (defcfe2) to head (4868f67).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #677   +/-   ##
=======================================
  Coverage   90.67%   90.67%           
=======================================
  Files          76       76           
  Lines       10117    10117           
  Branches    10117    10117           
=======================================
  Hits         9174     9174           
  Misses        861      861           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from 6cf38e5 to 64c7e41 Compare June 25, 2024 08:38
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from f30431b to 88fc2d1 Compare June 25, 2024 08:38
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from 64c7e41 to c683c25 Compare June 26, 2024 10:23
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from 88fc2d1 to a7bafa9 Compare June 26, 2024 10:24
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch 2 times, most recently from 5602db4 to 9d0bec0 Compare June 27, 2024 11:43
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from a7bafa9 to 0b876a7 Compare June 27, 2024 11:43
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from 9d0bec0 to 8257e32 Compare June 30, 2024 08:32
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from 0b876a7 to 2bf0cca Compare June 30, 2024 08:33
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch 2 times, most recently from fc63560 to 47fb3f1 Compare July 1, 2024 11:09
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from 2bf0cca to ab1710e Compare July 1, 2024 11:10
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch 2 times, most recently from ee8f106 to a0ba183 Compare July 2, 2024 12:52
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from ab1710e to f1f50e2 Compare July 2, 2024 12:52
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from a0ba183 to 89129d0 Compare July 8, 2024 07:31
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from f1f50e2 to 22bfdd3 Compare July 8, 2024 07:32
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from 89129d0 to 5839c99 Compare July 8, 2024 08:07
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from 22bfdd3 to a9e266b Compare July 8, 2024 08:07
@alonh5 alonh5 force-pushed the 06-19-create_phase_number_constants branch from 5839c99 to 69c7e59 Compare July 8, 2024 08:40
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from a9e266b to 266178b Compare July 8, 2024 10:30
@alonh5 alonh5 changed the base branch from 06-19-create_phase_number_constants to dev July 8, 2024 10:30
Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @shaharsamocha7)


crates/prover/src/examples/wide_fibonacci/simd.rs line 164 at r2 (raw file):

}

// TODO(AlonH): Implement.

its still not implemented

@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch 2 times, most recently from c772159 to 380101b Compare July 9, 2024 10:31
@alonh5 alonh5 force-pushed the 06-25-batch_inverse_lookup_column_denominators branch from 380101b to 4868f67 Compare July 9, 2024 11:54
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)


crates/prover/src/examples/wide_fibonacci/simd.rs line 164 at r2 (raw file):

Previously, ohad-starkware (Ohad) wrote…

its still not implemented

Right but I don't think the todo is necessary, there's a bunch of things still not implemented.

@ohad-starkware
Copy link
Collaborator

crates/prover/src/examples/wide_fibonacci/simd.rs line 164 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Right but I don't think the todo is necessary, there's a bunch of things still not implemented.

agreed

Copy link
Collaborator

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@alonh5 alonh5 merged commit 496323f into dev Jul 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants