Add wide fib lookup constraint.

[alonh5]

This change is 

[alonh5]

• Extract constraint code into functions. #644 : 2 dependent PRs (#646 , #654 )
• Use SecureField in interaction. #642
• Modify mask_points for interaction. #639
• Modify trace_log_degree_bounds for interaction. #638
• Add wide fib lookup constraint. #637 👈
• Add interaction to proof. #636
• Separate componenet and air trace writers. #651
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (1a13348) to head (822ff20).

Additional details and impacted files

@@                       Coverage Diff                       @@
##           05-19-add_interaction_to_proof     #637   +/-   ##
===============================================================
  Coverage                           92.74%   92.75%           
===============================================================
  Files                                  71       71           
  Lines                                9291     9300    +9     
  Branches                             9291     9300    +9     
===============================================================
+ Hits                                 8617     8626    +9     
  Misses                                595      595           
  Partials                               79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 1 of 5 files at r1, 1 of 7 files at r2, all commit messages.
Reviewable status: 2 of 9 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @andrewmilson)

---

crates/prover/src/core/constraints.rs line 71 at r2 (raw file):

) -> EF {
    let h = p - vanish_point.into_ef();
    h.y / (EF::one() + h.x)

How come that you have to change this?

Code quote:

    let h = p - vanish_point.into_ef();
    h.y / (EF::one() + h.x)

---

crates/prover/src/core/air/mod.rs line 53 at r2 (raw file):

    fn max_constraint_log_degree_bound(&self) -> u32;

    fn n_phases(&self) -> u32;

Can you also document?

Suggestion:

fn n_interaction_phases(&self) -> u32;

[alonh5]

Reviewable status: 2 of 9 files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)

---

crates/prover/src/core/constraints.rs line 71 at r2 (raw file):

Previously, shaharsamocha7 wrote…

How come that you have to change this?

Because I'm now using it in evaluate_constraint_quotients_at_point() where the point p is of qm31, and the vanishing point is a point from the trace domain.
Previously this was used when evaluating the oods quotient so it had to be the other way around (we stopped using it regardless of this PR).

---

crates/prover/src/core/air/mod.rs line 53 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Can you also document?

Done.

[spapinistarkware]

Reviewed 2 of 5 files at r1, 2 of 7 files at r2, 6 of 6 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)

[alonh5]

Merge activity

• Jun 20, 6:54 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
• Jun 20, 6:56 AM EDT: Graphite rebased this pull request as part of a merge.
• Jun 20, 6:58 AM EDT: @alonh5 merged this pull request with Graphite.