Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split prove function. #634

Merged
merged 1 commit into from
May 29, 2024
Merged

Split prove function. #634

merged 1 commit into from
May 29, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented May 19, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 92.24%. Comparing base (f5efd4b) to head (01b5898).

Files Patch % Lines
crates/prover/src/core/prover/mod.rs 88.37% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #634   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files          69       69           
  Lines        9034     9050   +16     
  Branches     9034     9050   +16     
=======================================
+ Hits         8333     8348   +15     
  Misses        629      629           
- Partials       72       73    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 7d320c6 to 4166596 Compare May 19, 2024 12:11
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 5211c30 to f537959 Compare May 19, 2024 12:11
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 4166596 to 599e5cd Compare May 19, 2024 14:45
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from f537959 to 2ba02cc Compare May 19, 2024 14:45
@alonh5 alonh5 mentioned this pull request May 19, 2024
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 599e5cd to 3a2f50f Compare May 19, 2024 14:50
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 2ba02cc to a75fca0 Compare May 19, 2024 14:50
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 3a2f50f to 68d7b88 Compare May 20, 2024 10:20
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from a75fca0 to 68ea002 Compare May 20, 2024 10:20
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 68d7b88 to 2572964 Compare May 22, 2024 14:05
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 68ea002 to f2cd2c8 Compare May 22, 2024 14:05
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 2572964 to 7dd3dce Compare May 23, 2024 07:40
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from f2cd2c8 to cbff692 Compare May 23, 2024 07:40
Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 7dd3dce to 5f62e91 Compare May 26, 2024 14:19
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from cbff692 to 6e432fc Compare May 26, 2024 14:19
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from 5f62e91 to e7f0a82 Compare May 26, 2024 14:48
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 6e432fc to f0e8255 Compare May 26, 2024 14:48
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from e7f0a82 to d80398b Compare May 27, 2024 07:34
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from f0e8255 to 87aa47b Compare May 27, 2024 07:34
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from d80398b to ef070f1 Compare May 27, 2024 07:45
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 87aa47b to 7611ea5 Compare May 27, 2024 07:45
@alonh5 alonh5 force-pushed the 05-19-create_componenttracewriter_trait branch from ef070f1 to 4395873 Compare May 28, 2024 12:14
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from 7611ea5 to f857eb6 Compare May 28, 2024 12:14
Copy link
Contributor Author

alonh5 commented May 29, 2024

Merge activity

  • May 29, 3:41 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
  • May 29, 3:43 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 29, 3:46 AM EDT: @alonh5 merged this pull request with Graphite.

@alonh5 alonh5 changed the base branch from 05-19-create_componenttracewriter_trait to dev May 29, 2024 07:41
@alonh5 alonh5 force-pushed the 05-19-split_prove_function branch from f857eb6 to 01b5898 Compare May 29, 2024 07:42
@alonh5 alonh5 merged commit 75353d1 into dev May 29, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants