Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wide fibonacci boundary constraint. #582

Merged
merged 1 commit into from
May 20, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Apr 17, 2024

This change is Reviewable

Copy link
Contributor Author

alonh5 commented Apr 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 4a29c59 to ee88b5e Compare April 18, 2024 07:34
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from e1cf158 to 8f64ec7 Compare April 18, 2024 07:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (3f1588d) to head (2eec1f7).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #582      +/-   ##
==========================================
+ Coverage   92.90%   93.44%   +0.53%     
==========================================
  Files          83       84       +1     
  Lines       11728    11952     +224     
  Branches    11728    11952     +224     
==========================================
+ Hits        10896    11168     +272     
+ Misses        755      701      -54     
- Partials       77       83       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from ee88b5e to d16c524 Compare April 18, 2024 08:18
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 8f64ec7 to a36072f Compare April 18, 2024 08:18
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from d16c524 to 8b357f0 Compare April 18, 2024 08:32
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from a36072f to 703ccce Compare April 18, 2024 08:32
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 8b357f0 to 1672d6f Compare April 18, 2024 09:06
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 703ccce to e80869a Compare April 18, 2024 09:06
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 1672d6f to 7f66643 Compare April 18, 2024 10:18
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from e80869a to 4f423a6 Compare April 18, 2024 10:18
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 7f66643 to 10f4a65 Compare April 21, 2024 09:01
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 4f423a6 to 59a92d8 Compare April 21, 2024 09:01
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 10f4a65 to 5ba1875 Compare April 25, 2024 12:33
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 59a92d8 to 3c26a96 Compare April 25, 2024 12:33
@alonh5 alonh5 mentioned this pull request Apr 25, 2024
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 5ba1875 to af64f12 Compare April 25, 2024 12:50
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 3c26a96 to bd4ce1e Compare April 25, 2024 12:50
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from af64f12 to 3e8ac7f Compare April 25, 2024 12:52
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from bd4ce1e to 8aaa9ff Compare April 25, 2024 12:52
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 3e8ac7f to 3c874f4 Compare April 30, 2024 08:11
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 8aaa9ff to 76d625c Compare April 30, 2024 08:11
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 3c874f4 to 103e762 Compare April 30, 2024 08:31
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 76d625c to 9d57c58 Compare April 30, 2024 08:31
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 103e762 to e3619c4 Compare April 30, 2024 09:03
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 5a5cd39 to 19a155b Compare April 30, 2024 09:45
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 6a55bfb to 74c2a20 Compare May 1, 2024 14:25
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 19a155b to 82c0561 Compare May 1, 2024 14:25
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 74c2a20 to fc5ada2 Compare May 1, 2024 14:34
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 82c0561 to 1111fbf Compare May 1, 2024 14:35
@alonh5 alonh5 requested a review from shaharsamocha7 May 7, 2024 14:22
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from fc5ada2 to fb894a1 Compare May 16, 2024 12:29
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 1111fbf to d5f68fc Compare May 16, 2024 12:29
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from fb894a1 to ed0fcd9 Compare May 16, 2024 13:36
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from d5f68fc to c2d33be Compare May 16, 2024 13:36
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch 2 times, most recently from 33f6f2b to cb07d27 Compare May 16, 2024 14:12
@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from c2d33be to 63c2304 Compare May 16, 2024 14:13
@alonh5 alonh5 changed the base branch from 04-09-separate_cpu_and_avx_wide_fib to dev May 16, 2024 14:13
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)


crates/prover/src/examples/wide_fibonacci/avx.rs line 89 at r2 (raw file):

                    PackedBaseField::zero(),
                    PackedBaseField::zero(),
                ]) * PackedSecureField::broadcast(accum.random_coeff_powers[self.n_columns() - 2]);

You also need to do the relevant changes in the component implementation.
I.e. you need to reduce the number of constraints by 1.

Code quote:

                PackedSecureField::from_packed_m31s([
                    a - PackedBaseField::one(),
                    PackedBaseField::zero(),
                    PackedBaseField::zero(),
                    PackedBaseField::zero(),
                ]) * PackedSecureField::broadcast(accum.random_coeff_powers[self.n_columns() - 2]);

@alonh5 alonh5 force-pushed the 04-17-remove_wide_fibonacci_boundary_constraint branch from 63c2304 to 2eec1f7 Compare May 19, 2024 11:55
@alonh5 alonh5 mentioned this pull request May 19, 2024
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


crates/prover/src/examples/wide_fibonacci/avx.rs line 89 at r2 (raw file):

Previously, shaharsamocha7 wrote…

You also need to do the relevant changes in the component implementation.
I.e. you need to reduce the number of constraints by 1.

Thanks. Done.

@alonh5 alonh5 mentioned this pull request May 19, 2024
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants