-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wide fibonacci boundary constraint. #582
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4a29c59
to
ee88b5e
Compare
e1cf158
to
8f64ec7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #582 +/- ##
==========================================
+ Coverage 92.90% 93.44% +0.53%
==========================================
Files 83 84 +1
Lines 11728 11952 +224
Branches 11728 11952 +224
==========================================
+ Hits 10896 11168 +272
+ Misses 755 701 -54
- Partials 77 83 +6 ☔ View full report in Codecov by Sentry. |
ee88b5e
to
d16c524
Compare
8f64ec7
to
a36072f
Compare
d16c524
to
8b357f0
Compare
a36072f
to
703ccce
Compare
8b357f0
to
1672d6f
Compare
703ccce
to
e80869a
Compare
1672d6f
to
7f66643
Compare
e80869a
to
4f423a6
Compare
7f66643
to
10f4a65
Compare
4f423a6
to
59a92d8
Compare
10f4a65
to
5ba1875
Compare
59a92d8
to
3c26a96
Compare
5ba1875
to
af64f12
Compare
3c26a96
to
bd4ce1e
Compare
af64f12
to
3e8ac7f
Compare
bd4ce1e
to
8aaa9ff
Compare
3e8ac7f
to
3c874f4
Compare
8aaa9ff
to
76d625c
Compare
3c874f4
to
103e762
Compare
76d625c
to
9d57c58
Compare
103e762
to
e3619c4
Compare
5a5cd39
to
19a155b
Compare
6a55bfb
to
74c2a20
Compare
19a155b
to
82c0561
Compare
74c2a20
to
fc5ada2
Compare
82c0561
to
1111fbf
Compare
fc5ada2
to
fb894a1
Compare
1111fbf
to
d5f68fc
Compare
fb894a1
to
ed0fcd9
Compare
d5f68fc
to
c2d33be
Compare
33f6f2b
to
cb07d27
Compare
c2d33be
to
63c2304
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/prover/src/examples/wide_fibonacci/avx.rs
line 89 at r2 (raw file):
PackedBaseField::zero(), PackedBaseField::zero(), ]) * PackedSecureField::broadcast(accum.random_coeff_powers[self.n_columns() - 2]);
You also need to do the relevant changes in the component implementation.
I.e. you need to reduce the number of constraints by 1.
Code quote:
PackedSecureField::from_packed_m31s([
a - PackedBaseField::one(),
PackedBaseField::zero(),
PackedBaseField::zero(),
PackedBaseField::zero(),
]) * PackedSecureField::broadcast(accum.random_coeff_powers[self.n_columns() - 2]);
63c2304
to
2eec1f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
crates/prover/src/examples/wide_fibonacci/avx.rs
line 89 at r2 (raw file):
Previously, shaharsamocha7 wrote…
You also need to do the relevant changes in the component implementation.
I.e. you need to reduce the number of constraints by 1.
Thanks. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is