-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate cpu and avx wide fib. #573
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #573 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 83 83
Lines 11728 11728
Branches 11728 11728
=======================================
Hits 10896 10896
Misses 755 755
Partials 77 77 ☔ View full report in Codecov by Sentry. |
7c87934
to
a5a2130
Compare
3e98a0a
to
adf1c7a
Compare
a5a2130
to
3724096
Compare
adf1c7a
to
8db68f6
Compare
3724096
to
32e9e84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @shaharsamocha7)
src/core/prover/mod.rs
line 122 at r2 (raw file):
} pub fn verify<B: Backend>(
Why do you want to support a non cpu verifier?
8db68f6
to
10c5627
Compare
32e9e84
to
a40a772
Compare
10c5627
to
288122c
Compare
1be87fe
to
6bee5d8
Compare
288122c
to
f490ef2
Compare
6bee5d8
to
4a29c59
Compare
f490ef2
to
a456638
Compare
4a29c59
to
ee88b5e
Compare
a456638
to
52a2d91
Compare
ee88b5e
to
d16c524
Compare
52a2d91
to
01cab65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)
src/core/prover/mod.rs
line 122 at r2 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Why do you want to support a non cpu verifier?
Done.
e5265a7
to
7687ffb
Compare
103e762
to
e3619c4
Compare
7687ffb
to
dba0e15
Compare
e3619c4
to
6a55bfb
Compare
dba0e15
to
8d8e6c8
Compare
6a55bfb
to
74c2a20
Compare
8d8e6c8
to
6c66326
Compare
74c2a20
to
fc5ada2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
6c66326
to
43307a3
Compare
fc5ada2
to
fb894a1
Compare
43307a3
to
1980413
Compare
fb894a1
to
ed0fcd9
Compare
ed0fcd9
to
33f6f2b
Compare
This change is