Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate cpu and avx wide fib. #573

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Apr 9, 2024

This change is Reviewable

@alonh5 alonh5 mentioned this pull request Apr 9, 2024
Copy link
Contributor Author

alonh5 commented Apr 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (9259c07) to head (33f6f2b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #573   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files          83       83           
  Lines       11728    11728           
  Branches    11728    11728           
=======================================
  Hits        10896    10896           
  Misses        755      755           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch 4 times, most recently from 7c87934 to a5a2130 Compare April 11, 2024 11:43
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from a5a2130 to 3724096 Compare April 11, 2024 14:21
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 3724096 to 32e9e84 Compare April 11, 2024 14:46
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @shaharsamocha7)


src/core/prover/mod.rs line 122 at r2 (raw file):

}

pub fn verify<B: Backend>(

Why do you want to support a non cpu verifier?

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 32e9e84 to a40a772 Compare April 17, 2024 10:41
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch 3 times, most recently from 1be87fe to 6bee5d8 Compare April 17, 2024 12:37
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 6bee5d8 to 4a29c59 Compare April 17, 2024 12:53
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 4a29c59 to ee88b5e Compare April 18, 2024 07:34
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from ee88b5e to d16c524 Compare April 18, 2024 08:18
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7 and @spapinistarkware)


src/core/prover/mod.rs line 122 at r2 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Why do you want to support a non cpu verifier?

Done.

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 103e762 to e3619c4 Compare April 30, 2024 09:03
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from e3619c4 to 6a55bfb Compare April 30, 2024 09:45
@alonh5 alonh5 force-pushed the 04-09-get_lookup_columns branch from dba0e15 to 8d8e6c8 Compare May 1, 2024 14:25
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 6a55bfb to 74c2a20 Compare May 1, 2024 14:25
@alonh5 alonh5 force-pushed the 04-09-get_lookup_columns branch from 8d8e6c8 to 6c66326 Compare May 1, 2024 14:34
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from 74c2a20 to fc5ada2 Compare May 1, 2024 14:34
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from fc5ada2 to fb894a1 Compare May 16, 2024 12:29
@alonh5 alonh5 force-pushed the 04-09-separate_cpu_and_avx_wide_fib branch from fb894a1 to ed0fcd9 Compare May 16, 2024 13:36
Copy link
Contributor Author

alonh5 commented May 16, 2024

Merge activity

  • May 16, 10:02 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
  • May 16, 10:07 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 16, 10:11 AM EDT: @alonh5 merged this pull request with Graphite.

@alonh5 alonh5 changed the base branch from 04-09-get_lookup_columns to dev May 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants