Remove wide fibonacci boundary constraint. (#582)

starkware-libs · May 20, 2024 · 8c5c6bb · 8c5c6bb
1 parent 403c45c
commit 8c5c6bb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 23 deletions.
diff --git a/crates/prover/src/examples/wide_fibonacci/avx.rs b/crates/prover/src/examples/wide_fibonacci/avx.rs
@@ -1,5 +1,5 @@
 use itertools::Itertools;
-use num_traits::{One, Zero};
+use num_traits::One;
 use tracing::{span, Level};
 
 use super::component::{WideFibAir, WideFibComponent};
@@ -80,14 +80,7 @@ impl ComponentProver<AVX512Backend> for WideFibComponent {
         for vec_row in 0..(1 << (eval_domain.log_size() - VECS_LOG_SIZE as u32)) {
             // Numerator.
             let a = trace_eval[0].data[vec_row];
-            let mut row_res =
-                PackedSecureField::from_packed_m31s([
-                    a - PackedBaseField::one(),
-                    PackedBaseField::zero(),
-                    PackedBaseField::zero(),
-                    PackedBaseField::zero(),
-                ]) * PackedSecureField::broadcast(accum.random_coeff_powers[self.n_columns() - 2]);
-
+            let mut row_res = PackedSecureField::zero();
             let mut a_sq = a.square();
             let mut b_sq = trace_eval[1].data[vec_row].square();
             #[allow(clippy::needless_range_loop)]

diff --git a/crates/prover/src/examples/wide_fibonacci/component.rs b/crates/prover/src/examples/wide_fibonacci/component.rs
@@ -1,5 +1,3 @@
-use num_traits::One;
-
 use crate::core::air::accumulation::PointEvaluationAccumulator;
 use crate::core::air::mask::fixed_mask_points;
 use crate::core::air::{Air, Component};
@@ -51,7 +49,7 @@ impl Air for WideFibAir {
 
 impl Component for WideFibComponent {
     fn n_constraints(&self) -> usize {
-        self.n_columns() - 1
+        self.n_columns() - 2
     }
 
     fn max_constraint_log_degree_bound(&self) -> u32 {
@@ -78,9 +76,6 @@ impl Component for WideFibComponent {
         let constraint_zero_domain = CanonicCoset::new(self.log_column_size()).coset;
         let denom = coset_vanishing(constraint_zero_domain, point);
         let denom_inverse = denom.inverse();
-        let numerator = mask[0][0] - BaseField::one();
-        evaluation_accumulator.accumulate(numerator * denom_inverse);
-
         for i in 0..self.n_columns() - 2 {
             let numerator = mask[i][0].square() + mask[i + 1][0].square() - mask[i + 2][0];
             evaluation_accumulator.accumulate(numerator * denom_inverse);

diff --git a/crates/prover/src/examples/wide_fibonacci/constraint_eval.rs b/crates/prover/src/examples/wide_fibonacci/constraint_eval.rs
@@ -1,5 +1,5 @@
 use itertools::Itertools;
-use num_traits::{One, Zero};
+use num_traits::Zero;
 
 use super::component::{Input, WideFibAir, WideFibComponent};
 use super::trace_gen::write_trace_row;
@@ -46,10 +46,6 @@ impl ComponentProver<CPUBackend> for WideFibComponent {
 
         #[allow(clippy::needless_range_loop)]
         for i in 0..trace_eval_domain.size() {
-            // Boundary constraint.
-            numerators[i] += accum.random_coeff_powers[self.n_columns() - 2]
-                * (trace_evals[0].values.at(i) - BaseField::one());
-
             // Step constraints.
             for j in 0..self.n_columns() - 2 {
                 numerators[i] += accum.random_coeff_powers[self.n_columns() - 3 - j]

diff --git a/crates/prover/src/examples/wide_fibonacci/mod.rs b/crates/prover/src/examples/wide_fibonacci/mod.rs
@@ -168,14 +168,14 @@ mod tests {
     }
 
     #[test_log::test]
-    fn test_prove() {
+    fn test_single_instance_wide_fib_prove() {
         // Note: To see time measurement, run test with
         //   RUST_LOG_SPAN_EVENTS=enter,close RUST_LOG=info RUST_BACKTRACE=1 cargo test
         //   test_prove -- --nocapture
 
-        const LOG_N_INSTANCES: u32 = 3;
+        const LOG_N_INSTANCES: u32 = 0;
         let component = WideFibComponent {
-            log_fibonacci_size: LOG_N_COLUMNS as u32,
+            log_fibonacci_size: 3 + LOG_N_COLUMNS as u32,
             log_n_instances: LOG_N_INSTANCES,
         };
         let private_input = (0..(1 << LOG_N_INSTANCES))