Skip to content

SER implementation tracker #7214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
36 of 41 tasks
simoll opened this issue Mar 17, 2025 · 1 comment
Open
36 of 41 tasks

SER implementation tracker #7214

simoll opened this issue Mar 17, 2025 · 1 comment

Comments

@simoll
Copy link
Contributor

simoll commented Mar 17, 2025 •
edited
Loading

Umbrella bug for tracking the SER implementation

DXIL opcodes + check-pass validation tests

DXIL opcode definitions and DXV tests showing wellformed dxil passing

HLSL -> HL lowering + sema

HLSL gen_intrin_main.txt definitions, HLSL -> DXIL lowering. HLSL + HL IR tests

Bug fixes | DXIL validation + check-fail validation tests

DXIL validation rules, in so far necessary, plus DXV tests with illformed dxil showing those validation failures

HLK tests

  • Basic SER execution tests ([SER] Basic execution tests #7379)
  • Wave-incoherent conditional assignment of HitObject values with and without procedural attributes
  • Dynamic access into local HitObject arrays
  • Adapt DXR 1.0 tests for HitObject
  • Adapt DXR 1.1 tests for HitObject
  • Test local root argument lookup with HitObject
  • Test MaybeReorderThread
  • Test all HitObject accessors in raygen
This was referenced Mar 17, 2025
Closed
Merged
@simoll
Copy link
Contributor Author

simoll commented Mar 20, 2025

Updated table with tracking bugs #7233 and #7234

simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 24, 2025
@simoll
[SER] Patch 1: HitObject type lowering and SM 6.9 enablement
4e441b2 
SER:
- dx::HitObject HLSL type.
- dx::HitObject::MakeNop as default ctor.
- dx::MaybeReorderThread HLSL intrinsic.
- Diagnostics for SER builtins in unsupported shader stages.
- SM6.9 AvailabilityAttributes on SER intrinsics and HitObject type.

Generic HLSL:
- 'static' gen_intrin_main.txt attribute to define static member
  functions.
- Enable 'min_sm' gen_intrin_main.txt attribute path.
- 'namespace dx' implementation, intrinsic declaration (derived from
  'namespace vk' impl) and lookup.

Generic diag:
- Diagnose AvailabilityAttribute of types (used for dx::HitObject).

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 24, 2025
@simoll
[SER] HitObject_MakeNop|Miss DXIL opcodes and verification tests
d8ebd34 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 24, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute
d1c9de9 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 24, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding
9501924 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 24, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding
c34e1e1 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Mar 24, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 25, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding
f7ac9b8 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 25, 2025
@simoll
[SER] MaybeReorderThread DXIL opcode and validation
f556b08 
- DXIL opcodes for MaybeReorderThread
- Validator rules
- DXV validation test (passing & expected failures)

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 25, 2025
@simoll
[SER] MaybeReorderThread DXIL opcode and validation
6237780 
- DXIL opcodes for MaybeReorderThread
- Validator rules
- DXV validation test (passing & expected failures)

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Mar 25, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 26, 2025
@simoll
[SER] DxHitObject::MakeNop|Miss lowering and tests
f79d0ca 
- HLSL -> DXIL lowering
- ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (microsoft#7214)
@simoll simoll mentioned this issue Mar 26, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 31, 2025
@simoll
[SER] HitObject accessors DXIL opcodes and check-pass tests
546773c 
DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 31, 2025
@simoll
[SER] HitObject accessors DXIL opcodes and check-pass tests
919dbf1 
DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 31, 2025
@simoll
[SER] HitObject accessors DXIL opcodes and check-pass tests
98c3926 
DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Mar 31, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 31, 2025
@simoll
[SER] HitObject_FromRayQuery[WithAttrs] DXIL opcodes and check-pass
59c89d1 
tests

DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Mar 31, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Mar 31, 2025
@simoll
[SER] HitObject_Invoke|TraceRay DXIL opcodes and check-pass test
e73afb0 
DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Mar 31, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 3, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding
1816cb5 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Apr 3, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 4, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding
33512df 
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR: microsoft/hlsl-specs#453

DXC SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 4, 2025
@simoll
[SER] HitObject accessors DXIL opcodes and check-pass tests
c40db9a 
DXC SER implementation tracker: microsoft#7214
tex3d pushed a commit that referenced this issue Apr 10, 2025
@simoll
[SER] 'reordercoherent' HLSL attribute and DXIL encoding (#7250)
90bfb66 
Specification:
https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

'reordercoherent' encoding hlsl-specs PR:
microsoft/hlsl-specs#453

DXC SER implementation tracker: #7214
tex3d pushed a commit that referenced this issue Apr 12, 2025
@simoll
[SER] HitObject_FromRayQuery[WithAttrs] DXIL opcodes and check-pass t…
0168df1 
…ests (#7277)

Add the DXIL operations and a passing validation test for:
- HitObject_FromRayQuery
- HitObject_FromRayQueryWithAttrs

DXC SER implementation tracker: #7214
tex3d pushed a commit that referenced this issue Apr 13, 2025
@simoll
[SER] HitObject accessors DXIL opcodes and check-pass tests (#7276)
94f9275 
Add the DXIL operations and a passing validation test for:
- HitObject_IsMiss, HitObject_IsHit, HitObject_IsNop
- HitObject_RayFlags, HitObject_RayTMin, HitObject_RayTCurrent
- HitObject_GeometryIndex, HitObject_InstanceIndex, HitObject_InstanceID
- HitObject_PrimitiveIndex, HitObject_HitKind, HitObject_ShaderTableIndex
- HitObject_WorldRayOrigin, HitObject_WorldRayDirection,
- HitObject_ObjectRayOrigin, HitObject_ObjectRayDirection
- HitObject_ObjectToWorld3x4, HitObject_WorldToObject3x4
- HitObject_SetShaderTableIndex, HitObject_LoadLocalRootTableConstant
- HitObject_Attributes

Closes #7310
DXC SER implementation tracker: #7214
@simoll simoll mentioned this issue Apr 17, 2025
Merged
tex3d pushed a commit that referenced this issue Apr 17, 2025
@simoll
[SER] MaybeReorderThread + Make(Nop|Miss) HLSL -> DXIL lowering and t…
0beaa76 
…ests (#7262)

- HLSL -> DXIL lowering
- ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (#7214)
tex3d pushed a commit that referenced this issue Apr 22, 2025
@simoll
[SER] TraceRay|Invoke HLSL -> DXIL lowering (#7355)
f19b5da 
Lowering for
- HitObject::TraceRay
- HitObject::Invoke

Specification:
https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker:: #7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 23, 2025
@simoll
[SER] HitObject::FromRayQuery HLSL -> DXIL lowering
90b3690 
* HLSL -> DXIL lowering
* ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (microsoft#7214)
@simoll simoll mentioned this issue Apr 23, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 23, 2025
@simoll
[SER] Validate HitObject accessors
b3602bd 
Validate:
 HitObject_GeometryIndex
 HitObject_HitKind
 HitObject_InstanceID
 HitObject_InstanceIndex
 HitObject_IsHit
 HitObject_IsMiss
 HitObject_IsNop
 HitObject_LoadLocalRootTableConstant
 HitObject_ObjectRayDirection
 HitObject_ObjectRayOrigin
 HitObject_ObjectToWorld3x4
 HitObject_PrimitiveIndex
 HitObject_RayFlags
 HitObject_RayTCurrent
 HitObject_RayTMin
 HitObject_SetShaderTableIndex
 HitObject_ShaderTableIndex
 HitObject_WorldRayDirection
 HitObject_WorldRayOrigin

Rules:
* No undef parameters (HitObject, RecordIndex, RootTableOffset)
* row/col/component indices are constant and in-bounds
* If constant, RootTableOffset % 4 == 0

SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Apr 23, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 23, 2025
@simoll
[SER] Validate MakeMiss
a4e4a40 
Validate:
 HitObject_MakeMiss

Rules:
 No undef MissIndex or RayFlags

SER implementation tracker: microsoft#7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 23, 2025
@simoll
[SER] Validate MakeMiss
e8f08a1 
Validate:
 HitObject_MakeMiss

Rules:
 No undef MissIndex or RayFlags

SER implementation tracker: microsoft#7214
This was referenced Apr 23, 2025
Merged
Closed
tex3d pushed a commit that referenced this issue Apr 23, 2025
@simoll
[SER] HitObject accessors HLSL -> DXIL lowering (#7360)
bddee27 
Lowering for all HitObject accessors (ex GetAttributes)

Specification:
https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker::
#7214
tex3d pushed a commit that referenced this issue Apr 23, 2025
@simoll
[SER] HitObject::GetAttributes HLSL -> DXIL lowering and attributes s…
847d5ad 
…ema (#7361)

Lowering for `HitObject::GetAttributes<T>()`

Specification:
https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker::
#7214
tex3d pushed a commit that referenced this issue Apr 24, 2025
@simoll
[SER] HitObject::FromRayQuery HLSL -> DXIL lowering (#7370)
624665f 
* HLSL -> DXIL lowering
* ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (#7214)
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 25, 2025
@simoll
[SER] Basic execution tests
6cb6843 
- All trivial scalar/vector/matrix getters
- HitObject::FromRayQuery with procedural hit
- HitObject::GetAttributes<T> with custom attributes and procedural hit

SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue Apr 25, 2025
Draft
damyanp pushed a commit that referenced this issue Apr 25, 2025
@simoll
[SER] Validate HitObject accessors (#7371)
0f7af1b 
Validate:
 HitObject_GeometryIndex
 HitObject_HitKind
 HitObject_InstanceID
 HitObject_InstanceIndex
 HitObject_IsHit
 HitObject_IsMiss
 HitObject_IsNop
 HitObject_LoadLocalRootTableConstant
 HitObject_ObjectRayDirection
 HitObject_ObjectRayOrigin
 HitObject_ObjectToWorld3x4
 HitObject_PrimitiveIndex
 HitObject_RayFlags
 HitObject_RayTCurrent
 HitObject_RayTMin
 HitObject_SetShaderTableIndex
 HitObject_ShaderTableIndex
 HitObject_WorldRayDirection
 HitObject_WorldRayOrigin

Rules:
* No undef parameters (HitObject, RecordIndex, RootTableOffset)
* row/col/component indices are constant and in-bounds
* If constant, RootTableOffset % 4 == 0

SER implementation tracker:
#7214
damyanp pushed a commit that referenced this issue Apr 25, 2025
@simoll
[SER] Validate MakeMiss (#7372)
b4d773f 
Validate:
 HitObject_MakeMiss

Rules:
 No undef MissShaderIndex or RayFlags

SER implementation tracker: #7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue Apr 28, 2025
@simoll
[SER] Validate HitObject::TraceRay|Invoke
22bbcaf 
Validate:
 HitObject_Invoke
 HitObject_TraceRay

Rules:
 No undef params
 Resource handle must be AS

SER implementation tracker: microsoft#7214
This was referenced Apr 28, 2025
Merged
Merged
damyanp pushed a commit that referenced this issue May 2, 2025
@simoll
[SER] Validate HitObject_FromRayQuery[WithAttrs] (#7402)
a4f8cf9 
Validate:
 HitObject_FromRayQuery
 HitObject_FromRayQueryWithAttrs

Rules:
 No `undef` inputs

SER implementation tracker: #7214
tex3d pushed a commit that referenced this issue May 2, 2025
@simoll
[SER] Validate HitObject::TraceRay|Invoke (#7384)
9536291 
Validate:
 HitObject_Invoke
 HitObject_TraceRay

Rules:
 No undef params
 Resource handle must be AS

SER implementation tracker: #7214
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue May 5, 2025
@simoll
[SER] REORDER_SCOPE check-fail validation tests
c340acf 
Show 'REODER_SCOPE' memory flag rejected pre DXIL 1.9. REORDER_SCOPE
validation logic already implemented in microsoft#7263

SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue May 5, 2025
Merged
simoll added a commit to simoll/DirectXShaderCompiler that referenced this issue May 5, 2025
@simoll
[SER] Validate 'reordercoherent' resource property
fa72b3b 
Validates:
 All resources
 All instructions using resources

Rules:
 'reordercoherent' may only be used in SM6.9+ in resource handles and
 resource declarations.
 Increment/DecrementCounter unsupported on 'reordercoherent' resources.

Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT'
container test and restore the old one without 'reordercoherent' (pre-microsoft#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and accepts from DXIL 1.9+.

SER implementation tracker: microsoft#7214
@simoll simoll mentioned this issue May 5, 2025
Merged
damyanp pushed a commit that referenced this issue May 6, 2025
@simoll
[SER] REORDER_SCOPE check-fail validation tests (#7428)
6f17379 
Show 'REORDER_SCOPE' memory flag rejected pre DXIL 1.9. REORDER_SCOPE
validation logic already implemented in #7263

Move REORDER_SCOPE validation tests to `LitDXILValidation/` and adapt
RUN lines as we are touching this (#7359).

SER implementation tracker: #7214
damyanp pushed a commit that referenced this issue May 9, 2025
@simoll @tex3d @github-actions
[SER] Validate 'reordercoherent' resource property (#7429)
474f9d2 
Validates:
 All resources
 All instructions using resources

Rules:
 'reordercoherent' may only be used in SM6.9+ in resource handles and
 resource declarations.
 Increment/DecrementCounter unsupported on 'reordercoherent' resources.

Create a new DXIL 1.9 variant of the 'CompileWhenOkThenCheckRDAT'
container test and restore the old one without 'reordercoherent'
(pre-#7250). The validator now rejects 'reordercoherent' in DXIL 1.3 and
accepts from DXIL 1.9+.

SER implementation tracker: #7214

---------

Co-authored-by: Tex Riddell <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simoll