Skip to content

[SER] REORDER_SCOPE Barrier semantic flag #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 10, 2025
Merged

[SER] REORDER_SCOPE Barrier semantic flag #7263

merged 10 commits into from
Apr 10, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Mar 26, 2025

  • HLSL REORDER_SCOPE flag (available from SM6.9)
  • Make validator accept REORDER_SCOPE from DXIL 1.9

@simoll simoll requested a review from a team as a code owner March 26, 2025 15:15
@simoll simoll mentioned this pull request Mar 26, 2025
Open
41 tasks
@damyanp damyanp added this to the Next Release milestone Mar 28, 2025
@simoll simoll force-pushed the ser_reorderscope_patch branch from 243336b to 7b41f68 Compare March 31, 2025 11:47
tex3d
tex3d reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bit more to be done, see the comments.

simoll and others added 4 commits April 3, 2025 13:24
@simoll
[SER] REORDER_SCOPE Barrier semantic flag
5dd89a3 
- HLSL REORDER_SCOPE flag (available from SM6.9)
- Make validator accept REORDER_SCOPE from DXIL 1.9
@simoll @tex3d
Update lib/DxilValidation/DxilValidation.cpp
8328f9e 
Co-authored-by: Tex Riddell <[email protected]>
@simoll
[ser] implement GetMinShaderModelAndMask for REORDER_SCOPE / legacy s…
f14637e 
…emantic flags (and diag msg)
@simoll
[ser] Add barrier_sm69 rdat test with REORDER_SCOPE
ada5df7
@simoll simoll force-pushed the ser_reorderscope_patch branch from 34d45a2 to ada5df7 Compare April 3, 2025 13:06
@simoll
Copy link
Contributor Author

simoll commented Apr 3, 2025

As for #7250, explicit tests for invalid dxil will be part of later PRs and this outstanding task is tracked in #7214

tex3d
tex3d previously approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Mainly minor comments on one test.

@simoll
Copy link
Contributor Author

simoll commented Apr 4, 2025

Made changes in acc with the minor comments. This is ready to merge for my taste.

damyanp
damyanp previously approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @tex3d, you'll need to submit a new review please.

tex3d
tex3d previously approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@simoll simoll dismissed stale reviews from tex3d and damyanp via a04dc34 April 7, 2025 07:44
@simoll simoll requested review from llvm-beanz and tex3d April 7, 2025 13:23
@tex3d tex3d merged commit bc9044a into microsoft:main Apr 10, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 10, 2025
@simoll simoll deleted the ser_reorderscope_patch branch April 11, 2025 09:28
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
simoll added a commit to simoll/DirectXShaderCompiler that referenced this pull request May 5, 2025
@simoll
[SER] REORDER_SCOPE check-fail validation tests
c340acf 
Show 'REODER_SCOPE' memory flag rejected pre DXIL 1.9. REORDER_SCOPE
validation logic already implemented in microsoft#7263

SER implementation tracker: microsoft#7214
@simoll simoll mentioned this pull request May 5, 2025
Merged
damyanp pushed a commit that referenced this pull request May 6, 2025
@simoll
[SER] REORDER_SCOPE check-fail validation tests (#7428)
6f17379 
Show 'REORDER_SCOPE' memory flag rejected pre DXIL 1.9. REORDER_SCOPE
validation logic already implemented in #7263

Move REORDER_SCOPE validation tests to `LitDXILValidation/` and adapt
RUN lines as we are touching this (#7359).

SER implementation tracker: #7214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

@damyanp damyanp damyanp left review comments

Assignees

@tex3d tex3d

@llvm-beanz llvm-beanz

Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@simoll @tex3d @damyanp @llvm-beanz