Skip to content

[SER] HitObject::FromRayQuery HLSL -> DXIL lowering #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

[SER] HitObject::FromRayQuery HLSL -> DXIL lowering #7370

merged 3 commits into from
Apr 24, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Apr 23, 2025

  • HLSL -> DXIL lowering
  • ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (#7214)

@simoll
[SER] HitObject::FromRayQuery HLSL -> DXIL lowering
90b3690 
* HLSL -> DXIL lowering
* ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (microsoft#7214)
@simoll simoll mentioned this pull request Apr 23, 2025
Open
41 tasks
@tex3d tex3d self-assigned this Apr 23, 2025
@tex3d tex3d moved this from New to In review in HLSL Roadmap Apr 23, 2025
tex3d
tex3d reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple points for follow up:

  • parameter name/type in AST seems misaligned - might be a general static method issue
  • missing scalarrepl-param-hlsl case for overload without attributes.

@simoll simoll mentioned this pull request Apr 23, 2025
Closed
@simoll
Copy link
Contributor Author

simoll commented Apr 23, 2025

A couple points for follow up:

  • parameter name/type in AST seems misaligned - might be a general static method issue
  • missing scalarrepl-param-hlsl case for overload without attributes.

damyanp
damyanp approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tex3d tex3d merged commit 624665f into microsoft:main Apr 24, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in HLSL Roadmap Apr 24, 2025
@simoll simoll deleted the ser_hlslfromrq_patch branch April 24, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@damyanp damyanp damyanp approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees

@tex3d tex3d

Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simoll @tex3d @damyanp @llvm-beanz