Skip to content

[SER] HitObject_FromRayQuery[WithAttrs] DXIL opcodes and check-pass #7277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2025
Merged

[SER] HitObject_FromRayQuery[WithAttrs] DXIL opcodes and check-pass #7277

merged 5 commits into from
Apr 12, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Mar 31, 2025

tests

DXC SER implementation tracker: #7214

@simoll simoll requested a review from a team as a code owner March 31, 2025 08:22
@simoll simoll mentioned this pull request Mar 31, 2025
Open
41 tasks
@damyanp damyanp added this to the Next Release milestone Mar 31, 2025
tex3d
tex3d reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two issues:

  • the ArgMemOnly attributes on the new DXIL ops should be changed to ReadOnly
  • the test under DXILValidatoin will not be run and needs to be moved to LitDXILValidation

@simoll simoll requested a review from tex3d April 11, 2025 09:27
tex3d
tex3d approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tex3d tex3d merged commit 0168df1 into microsoft:main Apr 12, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 12, 2025
@simoll simoll deleted the ser_dxilfromrq_patch branch April 14, 2025 05:55
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees

@tex3d tex3d

@llvm-beanz llvm-beanz

Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@simoll @tex3d @llvm-beanz @damyanp