Skip to content

[SER] MaybeReorderThread DXIL opcode and validation #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 14, 2025
Merged

[SER] MaybeReorderThread DXIL opcode and validation #7256

merged 8 commits into from
Apr 14, 2025

Conversation

simoll
Copy link
Contributor

@simoll simoll commented Mar 25, 2025

  • DXIL opcodes for MaybeReorderThread
  • Validator rules
  • DXV validation test (passing & expected failures)

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: #7214

@simoll
[SER] MaybeReorderThread DXIL opcode and validation
6237780 
- DXIL opcodes for MaybeReorderThread
- Validator rules
- DXV validation test (passing & expected failures)

Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md

DXC SER implementation tracker: microsoft#7214
@simoll simoll requested a review from a team as a code owner March 25, 2025 19:25
@simoll simoll mentioned this pull request Mar 25, 2025
Open
41 tasks
@damyanp damyanp added this to the Next Release milestone Mar 28, 2025
@simoll
Copy link
Contributor Author

simoll commented Apr 11, 2025 •
edited
Loading

Changed dxil validation rules in acc with microsoft/hlsl-specs#485

  • HitObject must not be undef
  • NumCoherenceBits must not be undef
  • CoherenceBits must not be undef when NumCoherenceBits != 0

also updated passing and failing validation test cover those cases

EDIT: HitObject_MakeNop for reorder without HO is only relevant for the HLSL-> DXIL lowering

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

✅ With the latest revision this PR passed the Python code formatter.

@simoll simoll requested a review from llvm-beanz April 14, 2025 11:58
tex3d
tex3d reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DXIL op is missing category and shader model, otherwise looks good.

tex3d
tex3d approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, but I'm the last one who pushed changes, so it needs a new independent review.

@simoll simoll requested a review from llvm-beanz April 14, 2025 19:28
@tex3d tex3d merged commit b5a9cd5 into microsoft:main Apr 14, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 14, 2025
@simoll simoll deleted the ser_dxilreorder_patch branch April 15, 2025 04:37
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees

@tex3d tex3d

@llvm-beanz llvm-beanz

Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
4 participants
@simoll @tex3d @llvm-beanz @damyanp