AP_HAL_ChibiOS: do not run through SPI_RX and TX as well #28409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we use MISO and MOSI name for SPI
bugobliterator
force-pushed
the
pr-spi-gpio-duplicate
branch
from
37065a1
to
356eb4f
Compare
tridge
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where we run GPIO loop through SPI two times per pin as we duplicate MISO and MOSI name with RX and TX as well. So if we have GPIO(x) next to SPI the hwdef fails to compile, and does not allow SPI lines to also be treated as GPIO.