-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(operations): Add builder for armv7-unknown-linux-musleabihf #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
|
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
@@ -0,0 +1,332 @@ | |||
ARG RUST_VERSION=1.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this seems repeated from our other musl container? I think this would be a good point to break this out into its own script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to combine this and the other one into a single Dockerfile when doing #946. For now the goal is to just have Vector compiled and running on the new platoform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me! I am just eager to get #946 done 😄
Signed-off-by: Alexander Rodin <[email protected]>
Now Vector and the tests (not integration ones) can be executed. The current status of the tests:
|
Nice! Do you know how to resolve the failing test? And how can we perform this check in CI? |
The segmentation fault in
There are two ways, one is to run QEMU virtual machine emulating ARMv7 in CircleCI and another is to spawn an A1 instance from CI to run the tests. I prefer the first approach because it would allow anyone to run these tests locally and I find it more convenient to have all tests running in one place if it is possible. |
It turns out that for statically linked binaries it is possible to just install package |
The |
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
…nown-linux-musleabihf Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
…n-linux-musleabihf Signed-off-by: Alexander Rodin <[email protected]>
…v7-unknown-linux-musleabihf Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
So close! @a-rodin what are you thinking the ETA is on this? Looking really good. |
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
@binarylogic It is ready! |
Nice! I know you had to branch out a lot to support this. Great work! We'll be launching marketing pages to promote this + IOT in general. |
@a-rodin, @LucioFranco is out until the 25th. Would you prefer to wait, have someone else review, or go ahead and merge? I can also find someone that has more knowledge in this domain to review, but you clearly know what you're doing 😄 . |
I think we can merge it, as it doesn’t break anything and subsequent changes in the build process would not be breaking changes. |
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
Hello. Is it planned to publish a docker image for the arm architecture? |
@HelloEdit Yes! Issue #1196 represents it. |
Closes #859
This is an early stage builder for
armv7-unknown-linux-musleabihf
. It is able to produce binaries, but at the moment it supports onlyjemallocator
feature, and notleveldb
andrdkafka
.The problem with
leveldb
is that it expects a special configure flag saying that we are in a cross-compilation environment, andleveldb-sys
crate doesn't pass it to the configure script.rdkafka
has some issues related to the SSL library.Also it uses LLD as the linker, so we would need to address #1035 before merging or use
ld
from the GCC toolchain for ARM.