-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use most recent/portable versions of LevelDB and Snappy dependencies #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just to note the author of |
It sounds like we should definitely do this. @LucioFranco can you have him give us access? Is there any we didn't take him up on that? |
@binarylogic I say let us discuss this more on Monday but I was not sure if we wanted to take up more work with |
What is the alternative? I do not want to block this issue to move off of leveldb. Moving off of leveldb will likely be a larger project addressed in https://github.com/timberio/vector/milestone/23; it is not something I want to rush or do haphazardly. |
@a-rodin just documenting a discussion in Slack. We'd like to fork the |
Note that we need to add CMake to list of our development requirements with this upgrade, as newer versions of LevelDB use it as the build system. |
I think that for now we can keep the same version of |
Currently the most recent version of
leveldb-sys
crate that we use for disk buffers depends on LevelDB 1.18. The latest upstream release of LevelDB is 1.22 (changelog).In particular, version 1.21 added native Windows support, which could be very useful for #880.
Also, as mentioned in #1054, the version 1.1.2 of Snappy used by
leveldb-sys
has an Autotools-based build scripts, which make it less flexible about cross-compilation (in particular, a special flag has to be passed to the configure script, andlevelb-sys
build script doesn't support passing it). The most recent version 1.1.7 of Snappy supports CMake, which supports reading of build configuration from environment variables, so updating it could have simplified building for ARM.Thus, it would be helpful to have an updated version of
leveldb-sys
crate supporting most recent versions of LevelDB and Snappy in order to support more targets.The text was updated successfully, but these errors were encountered: