Skip to content

fix(file source): Increase sleep interval in the tests for file source #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Oct 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2019

On some occurrences the sleep interval in tests for file source turns out to be too small, which makes the tests fail. This PR increases it 10x to make sure that that interval is large enough for all test platforms.

Ref #1054 (comment)

@ghost ghost merged commit 9e2f98e into master Oct 29, 2019
@binarylogic
Copy link
Contributor

😦 I wish we could deterministicly wait, but whatever works for now.

@lukesteensen
Copy link
Member

@binarylogic I'm open to any ideas you have on how to improve these tests 😉

@binarylogic
Copy link
Contributor

The only idea I have is to offer a function we can call that would perform the file read iteration and block. This way the function could be called instead of waiting an arbitrary amount of time. Example pseudo code:

file.write('some content')
file_source.refresh() // blocks until done
// make test assertion

Would that be possible?

@ghost ghost deleted the file-source-increase-test-sleep-interval branch November 20, 2019 16:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants