chore(operations): Update Rusoto to 0.38.0 #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David O'Rourke <[email protected]>
|
Interesting. |
Signed-off-by: David O'Rourke <[email protected]>
|
I'm not sure that failure is related to this change, it appears to be multiline and read issues in the file source. |
LucioFranco
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
LGTM! @lukesteensen you might know why these tests are failing?
Signed-off-by: David O'Rourke <[email protected]>
|
I think that tests are failing for the same reason as in this comment - the sleep interval in file source tests sometimes turns out to be too small. I've created #1113 to address it. |
|
@phyber thanks for this! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Rusoto to 0.38.0 and adds a few
vimfiles to the.gitignore, taking care of the first step of #1103.All tests in
cargo testare passing on Linux after this change. Hopefully I got the PR title right :)