Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task_augur_refine iqd back to 4 #268

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

jrotieno
Copy link
Contributor

@jrotieno jrotieno commented Dec 14, 2023

Closes #249

🛠️ Changes Being Made

Reverted the augur refine input clock_filter_iqd to previous default value of 4.

Impacted Workflows/Tasks

task_augur_refine.wdl

🧠 Context and Rationale

The default was changed when working with monkeypox genomes, all clades and not just the outbreak clade IIb, where some crucial sequences in understanding the full evolutionary history of the pathogen were getting removed as outliers.

We are changing this back to the previous default of 4, which is perfect for SARS-CoV-2, but will advise users to change it accordingly depending on the pathogen, especially where genuine outliers (not sequencing or dating artefacts) are expected.

📋 Workflow/Task Steps

Inputs

Outputs

Impacted Outputs

🧪 Testing

Locally

Terra

Scenarios for Reviewer to Test

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

Copy link

@emily-smith1 emily-smith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested the jro_augur_refine_patch on a set of 6 SARS-CoV-2 genomes from the augur_test_2023-12-14 table in this workspace. The resulting tree look as expected with only those 6 included samples.

@jrotieno jrotieno merged commit 705626e into main Dec 15, 2023
4 checks passed
@jrotieno jrotieno deleted the jro_augur_refine_patch branch December 15, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augur tree has wild inferred date of Wuhan-1 reference genome for SC2
2 participants