Eval framework info

[spapinistarkware]

This change is 

[spapinistarkware]

• Blake statement #781
• Blake air #773
• Blake scheduler #770
• Blake round #767
• Optimized lookup combine #765
• Blake xor table #764
• Framework component #761
• Poseidon with logup #712
• Logup trace generation #711
• is_first constant column #710
• Poseidon plain proof #708
• ProverCommitmentScheme::commit_on_evals() #707
• Eval framework info #715 👈
• Eval framework asserts #714
• Eval framework point and domain #713
• Eval framework #706
• Eval framework preperation #705
• Generalize AirExt::mask_points() #704
• Wrap mask with TreeVec #702
• Generalize component_trace() #701
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.20%. Comparing base (a69e8ca) to head (890386f).

Files	Patch %	Lines
crates/prover/src/constraint_framework/info.rs	0.00%	26 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #715      +/-   ##
==========================================
- Coverage   90.43%   90.20%   -0.23%     
==========================================
  Files          80       81       +1     
  Lines       10328    10354      +26     
  Branches    10328    10354      +26     
==========================================
  Hits         9340     9340              
- Misses        904      930      +26     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/info.rs line 11 at r1 (raw file):

#[derive(Default)]
pub struct InfoEvaluator {

Document that this is used to collect the mask offsets and count the constraints for a specific component.

Code quote:

pub struct InfoEvaluator {

---

crates/prover/src/constraint_framework/info.rs line 30 at r1 (raw file):

        if self.mask_offsets.len() <= interaction {
            self.mask_offsets.resize(interaction + 1, vec![]);
        }

This code assumes that 'interaction` is continuous (which is true) but it may be called differently
Alternatively handle that differently

Suggestion:

        if self.mask_offsets.len() <= interaction {
            assert_eq(self.mask_offsets.len() == interaction + 1);
            self.mask_offsets.resize(interaction + 1, vec![]);
        }

---

crates/prover/src/constraint_framework/info.rs line 41 at r1 (raw file):

    }

    fn combine_ef(_values: [Self::F; 4]) -> Self::EF {

Fix

Suggestion:

    fn combine_ef(values: [Self::F; SECURE_EXTENSION_DEGREE]) -> Self::EF {

[spapinistarkware]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/info.rs line 11 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Document that this is used to collect the mask offsets and count the constraints for a specific component.

Done.

---

crates/prover/src/constraint_framework/info.rs line 30 at r1 (raw file):

Previously, shaharsamocha7 wrote…

This code assumes that 'interaction` is continuous (which is true) but it may be called differently
Alternatively handle that differently

As discussed.

---

crates/prover/src/constraint_framework/info.rs line 41 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Fix

Done.

[shaharsamocha7]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Merge activity

• Jul 14, 8:18 AM EDT: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Jul 14, 8:20 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 14, 8:23 AM EDT: @spapinistarkware merged this pull request with Graphite.