Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap mask with TreeVec #702

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Jul 4, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.26%. Comparing base (ab2322c) to head (9170555).

Files Patch % Lines
crates/prover/src/core/prover/mod.rs 94.73% 0 Missing and 1 partial ⚠️
crates/prover/src/trace_generation/registry.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #702      +/-   ##
==========================================
- Coverage   90.29%   90.26%   -0.03%     
==========================================
  Files          75       75              
  Lines        9960     9946      -14     
  Branches     9960     9946      -14     
==========================================
- Hits         8993     8978      -15     
- Misses        886      889       +3     
+ Partials       81       79       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/07-04-wrap_mask_with_treevec branch from 84928d9 to 9170555 Compare July 5, 2024 05:26
@spapinistarkware spapinistarkware changed the base branch from spapini/07-04-generalize_component_trace_ to dev July 5, 2024 05:26
Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Nice!

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants