Eval framework asserts

[spapinistarkware]

This change is 

[spapinistarkware]

• Blake statement #781
• Blake air #773
• Blake scheduler #770
• Blake round #767
• Optimized lookup combine #765
• Blake xor table #764
• Framework component #761
• Poseidon with logup #712
• Logup trace generation #711
• is_first constant column #710
• Poseidon plain proof #708
• ProverCommitmentScheme::commit_on_evals() #707
• Eval framework info #715
• Eval framework asserts #714 👈
• Eval framework point and domain #713
• Eval framework #706
• Eval framework preperation #705
• Generalize AirExt::mask_points() #704
• Wrap mask with TreeVec #702
• Generalize component_trace() #701
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.43%. Comparing base (4839cd8) to head (ef45c3c).

Files	Patch %	Lines
crates/prover/src/constraint_framework/assert.rs	92.59%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #714      +/-   ##
==========================================
+ Coverage   90.42%   90.43%   +0.01%     
==========================================
  Files          79       80       +1     
  Lines       10274    10328      +54     
  Branches    10274    10328      +54     
==========================================
+ Hits         9290     9340      +50     
- Misses        901      904       +3     
- Partials       83       84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/mod.rs line 2 at r1 (raw file):

/// ! This module contains helpers to express and use constraints for components.
mod assert;

Is this uses only for tests?

Code quote:

mod assert;

[shaharsamocha7]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/assert.rs line 38 at r1 (raw file):

        offsets.map(|off| {
            self.trace[interaction][col_index][(self.row as isize + off)
                .rem_euclid(self.trace[interaction][col_index].len() as isize)

Can you extract this to a variable col_length?
I think it will make it more clear

Maybe also add a comment that the mask overflows

Code quote:

self.trace[interaction][col_index].len() as isize

---

crates/prover/src/constraint_framework/assert.rs line 48 at r1 (raw file):

    {
        let res = SecureField::one() * constraint;
        assert_eq!(res, SecureField::zero(), "row: {}", self.row);

Add a comment that we expect this to be zero because we evaluate directly on the trace points.
Not sure if it belongs here or in the doc of AssertEvaluator

Code quote:

assert_eq!(res, SecureField::zero(), "row: {}", self.row);

[spapinistarkware]

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/assert.rs line 38 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you extract this to a variable col_length?
I think it will make it more clear

Maybe also add a comment that the mask overflows

Done.

---

crates/prover/src/constraint_framework/assert.rs line 48 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Add a comment that we expect this to be zero because we evaluate directly on the trace points.
Not sure if it belongs here or in the doc of AssertEvaluator

Done.

---

crates/prover/src/constraint_framework/mod.rs line 2 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Is this uses only for tests?

It won't be on production. But very useful for debugging, from experience.

[shaharsamocha7]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/assert.rs line 50 at r2 (raw file):

        // Cast to SecureField.
        let res = SecureField::one() * constraint;
        // The constraint should be zero at the given row, since we are evaluating on the trace.

non-blocking

Suggestion:

since we are evaluating on the trace domain.

---

crates/prover/src/constraint_framework/mod.rs line 2 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

It won't be on production. But very useful for debugging, from experience.

I suggested adding #[cfg(tests)]

[spapinistarkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

crates/prover/src/constraint_framework/mod.rs line 2 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I suggested adding #[cfg(tests)]

It's useful as a library, so I don't think I want to gate this.

[shaharsamocha7]

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @spapinistarkware)

[shaharsamocha7]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @spapinistarkware)

---

crates/prover/src/constraint_framework/assert.rs line 55 at r4 (raw file):

    }

    fn combine_ef(values: [Self::F; 4]) -> Self::EF {

Fix

Suggestion:

    fn combine_ef(values: [Self::F; SECURE_EXTENSION_DEGREE]) -> Self::EF {

[shaharsamocha7]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Merge activity

• Jul 14, 8:06 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
• Jul 14, 8:18 AM EDT: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Jul 14, 8:18 AM EDT: @spapinistarkware merged this pull request with Graphite.