ProverCommitmentScheme::commit_on_evals()

[spapinistarkware]

This change is 

[spapinistarkware]

• Blake statement #781
• Blake air #773
• Blake scheduler #770
• Blake round #767
• Optimized lookup combine #765
• Blake xor table #764
• Framework component #761
• Poseidon with logup #712
• Logup trace generation #711
• is_first constant column #710
• Poseidon plain proof #708
• ProverCommitmentScheme::commit_on_evals() #707 👈
• Eval framework info #715
• Eval framework asserts #714
• Eval framework point and domain #713
• Eval framework #706
• Eval framework preperation #705
• Generalize AirExt::mask_points() #704
• Wrap mask with TreeVec #702
• Generalize component_trace() #701
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (2c6cbfd) to head (a4f2daf).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #707   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          81       81           
  Lines       10354    10356    +2     
  Branches    10354    10356    +2     
=======================================
+ Hits         9340     9342    +2     
  Misses        930      930           
  Partials       84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/core/pcs/prover.rs line 61 at r1 (raw file):

        &mut self,
        evals: ColumnVec<CircleEvaluation<B, BaseField, BitReversedOrder>>,
        channel: &mut Blake2sChannel,

?

Suggestion:

        channel: &mut ProofChannel,

---

crates/prover/src/core/pcs/prover.rs line 64 at r1 (raw file):

        twiddles: &TwiddleTree<B>,
    ) {
        let span = span!(Level::INFO, "Interpolation").entered();

Do we care that this interpolation is for commitment? and not for constraints?

Suggestion:

        let span = span!(Level::INFO, "Interpolation for commitment").entered();

[spapinistarkware]

Reviewed 1 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/core/pcs/prover.rs line 61 at r1 (raw file):

Previously, shaharsamocha7 wrote…

?

Done.

---

crates/prover/src/core/pcs/prover.rs line 64 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Do we care that this interpolation is for commitment? and not for constraints?

Done.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)