Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicates keys #15257

Closed
wants to merge 3 commits into from
Closed

remove duplicates keys #15257

wants to merge 3 commits into from

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Jun 16, 2017

c.f. ros-infrastructure/rosdep#520

some of rosdep keys is multiply defined, and that sometime confuse users.

  • rename xdot in python.yaml to python-xdot, because xdot is already taken by ros package, at least until indigo http://wiki.ros.org/xdot

change xdot to python-xdot, this will break backward compatibility....

  • pocketsphinx is already taken by ros package(http://wiki.ros.org/pocketsphinx)
    and that different from pocketsphinx system package,
    libshphinxbase is library and pocketsphinx installs some application binaries, so they are different too

this changes pocketsphinx key in base.yaml to pocketsphinx-bin, this also breaks compatibility, but that was added just a few month ago


ubuntu-14:~$ dpkg -L libsphinxbase1
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/libsphinxbase1
/usr/share/doc/libsphinxbase1/copyright
/usr/share/doc/libsphinxbase1/changelog.Debian.gz
/usr/lib
/usr/lib/libsphinxbase.so.1.1.1
/usr/lib/libsphinxad.so.0.0.1
/usr/lib/libsphinxbase.so.1
/usr/lib/libsphinxad.so.0
ubuntu-14:~$ dpkg -L libpocketsphinx1/.
/usr
/usr/lib
/usr/lib/libpocketsphinx.so.1.1.0
/usr/share
/usr/share/doc
/usr/share/doc/libpocketsphinx1
/usr/share/doc/libpocketsphinx1/copyright
/usr/share/doc/libpocketsphinx1/changelog.Debian.gz
/usr/lib/libpocketsphinx.so.1


ubuntu-16:~$ dpkg -L pocketsphinx
/.
/usr
/usr/bin
/usr/bin/pocketsphinx_mdef_convert
/usr/bin/pocketsphinx_continuous
/usr/bin/pocketsphinx_batch
/usr/share
/usr/share/doc
/usr/share/doc/pocketsphinx
/usr/share/doc/pocketsphinx/copyright
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/pocketsphinx_batch.1.gz
/usr/share/man/man1/pocketsphinx_continuous.1.gz
/usr/share/man/man1/pocketsphinx_mdef_convert.1.gz
/usr/share/doc/pocketsphinx/changelog.Debian.gz

ubuntu-16:~$ dpkg -L libpocketsphinx3
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libpocketsphinx.so.3.0.0
/usr/share
/usr/share/doc
/usr/share/doc/libpocketsphinx3
/usr/share/doc/libpocketsphinx3/copyright
/usr/share/doc/libpocketsphinx3/changelog.Debian.gz
/usr/lib/x86_64-linux-gnu/libpocketsphinx.so.3

  • remove python-* in base.yaml, which already defined in python.yaml

This just to remove duplicates entry from base.yaml, no regressions.

k-okada added 3 commits June 16, 2017 13:04
…etsphinx) and that different from pocketsphinx system package, libshphinxbase is library and pocketsphinx installs some application binaries, so they are differnet too
@tfoote
Copy link
Member

tfoote commented Jun 16, 2017

@k-okada Could you split this into 3 separate PRs?

The removal of straight duplicates is low impact. However the other two changes we should do a best effort to contact all known users as well as annouce the changes publicly and leave the PRs open for a review period to make sure that people have time to comment if it will significantly effect them.

Also the naming on pocketsphinx is different than we discussed in #14126 and the renames are causing at least one rule to be out of alphabetical order.

@k-okada
Copy link
Contributor Author

k-okada commented Jun 16, 2017

@tfoote thanks for comment, split into 3 PRs #15258 #15259 #15260

@k-okada k-okada closed this Jun 16, 2017
@k-okada k-okada deleted the fix_duplicates branch June 16, 2017 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants