Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove python-* in base.yaml, which already defined in python.yaml #15258

Merged
merged 2 commits into from
Jun 17, 2017
Merged

remove python-* in base.yaml, which already defined in python.yaml #15258

merged 2 commits into from
Jun 17, 2017

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Jun 16, 2017 •
edited
Loading

rewrited version of #15257

some of rosdep keys is multiply defined, and that sometime confuse users.

  • This just to remove duplicates entry from base.yaml, no regressions.

@k-okada k-okada mentioned this pull request Jun 16, 2017
Closed
@k-okada k-okada closed this Jun 16, 2017
@k-okada k-okada deleted the fix_duplicates_python branch June 16, 2017 06:46
@k-okada k-okada restored the fix_duplicates_python branch June 16, 2017 06:47
@k-okada k-okada reopened this Jun 16, 2017
@mathias-luedtke
Copy link
Contributor

To avoid further confusion, what about moving all python-* keys into python.yaml by policy?

mikaelarguedas
mikaelarguedas requested changes Jun 16, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One rule is removed here and doesn't exist in the python.yaml file.

rosdep/base.yaml
fedora: [python-sphinx]
gentoo: [dev-python/sphinx]
python-tornado:
arch: [python-tornado]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the arch key to the python.yaml file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catch! done

mikaelarguedas
mikaelarguedas approved these changes Jun 17, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for iterating

@mikaelarguedas mikaelarguedas merged commit 57f369d into ros:master Jun 17, 2017
@k-okada k-okada deleted the fix_duplicates_python branch June 17, 2017 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-okada @mathias-luedtke @tfoote @mikaelarguedas