Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pocketsphinx is already taken by ros package(http://wiki.ros.org/pock… #15260

Merged
merged 1 commit into from
Jun 29, 2017
Merged

pocketsphinx is already taken by ros package(http://wiki.ros.org/pock… #15260

merged 1 commit into from
Jun 29, 2017

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Jun 16, 2017 •
edited
Loading

…etsphinx) and that different from pocketsphinx system package, libshphinxbase is library and pocketsphinx installs some application binaries, so they are differnet too

rewrited version of #15257

some of rosdep keys is multiply defined, and that sometime confuse users.

pocketsphinx is already taken by ros package(http://wiki.ros.org/pocketsphinx)
and that different from pocketsphinx system package,
libshphinxbase is library and pocketsphinx installs some application binaries, so they are different too
this changes pocketsphinx key in base.yaml to pocketsphinx-bin, this also breaks compatibility, but that was added just a few month ago

ubuntu-14:~$ dpkg -L libsphinxbase1
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/libsphinxbase1
/usr/share/doc/libsphinxbase1/copyright
/usr/share/doc/libsphinxbase1/changelog.Debian.gz
/usr/lib
/usr/lib/libsphinxbase.so.1.1.1
/usr/lib/libsphinxad.so.0.0.1
/usr/lib/libsphinxbase.so.1
/usr/lib/libsphinxad.so.0
ubuntu-14:~$ dpkg -L libpocketsphinx1/.
/usr
/usr/lib
/usr/lib/libpocketsphinx.so.1.1.0
/usr/share
/usr/share/doc
/usr/share/doc/libpocketsphinx1
/usr/share/doc/libpocketsphinx1/copyright
/usr/share/doc/libpocketsphinx1/changelog.Debian.gz
/usr/lib/libpocketsphinx.so.1


ubuntu-16:~$ dpkg -L pocketsphinx
/.
/usr
/usr/bin
/usr/bin/pocketsphinx_mdef_convert
/usr/bin/pocketsphinx_continuous
/usr/bin/pocketsphinx_batch
/usr/share
/usr/share/doc
/usr/share/doc/pocketsphinx
/usr/share/doc/pocketsphinx/copyright
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/pocketsphinx_batch.1.gz
/usr/share/man/man1/pocketsphinx_continuous.1.gz
/usr/share/man/man1/pocketsphinx_mdef_convert.1.gz
/usr/share/doc/pocketsphinx/changelog.Debian.gz

ubuntu-16:~$ dpkg -L libpocketsphinx3
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/libpocketsphinx.so.3.0.0
/usr/share
/usr/share/doc
/usr/share/doc/libpocketsphinx3
/usr/share/doc/libpocketsphinx3/copyright
/usr/share/doc/libpocketsphinx3/changelog.Debian.gz
/usr/lib/x86_64-linux-gnu/libpocketsphinx.so.3
```

This was referenced Jun 16, 2017
Closed
Merged
@dirk-thomas
Copy link
Member

This needs to be rebased.

@k-okada k-okada force-pushed the fix_duplicates_pocketsphinx branch from 3ea7a31 to 1101757 Compare June 28, 2017 22:45
@k-okada
Copy link
Contributor Author

k-okada commented Jun 28, 2017

@dirk-thomas ok, done.

@dirk-thomas dirk-thomas requested a review from tfoote June 28, 2017 22:51
tfoote
tfoote requested changes Jun 28, 2017
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for renaming the colliding key.

However we should not remove all those older rules as some are note even EOL and there's not much value in collapsing only some of them.

@k-okada
pocketsphinx is already taken by ros package(http://wiki.ros.org/pock…
f31d827 
…etsphinx) and that different from pocketsphinx system package, libshphinxbase is library and pocketsphinx installs some application binaries, so they are differnet too
@k-okada k-okada force-pushed the fix_duplicates_pocketsphinx branch from 1101757 to f31d827 Compare June 28, 2017 23:48
@k-okada
Copy link
Contributor Author

k-okada commented Jun 28, 2017

ok, now we just changed key name

tfoote
tfoote approved these changes Jun 29, 2017
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with announcement mentioned in #15259

@k-okada k-okada mentioned this pull request Jun 29, 2017
Open
@tfoote
Copy link
Member

tfoote commented Jun 29, 2017

Thanks @k-okada the post and grepping for the keys is about all we can do.

@ros/rosdistro-maintainers all set for merge.

@dirk-thomas
Copy link
Member

No released ROS packages seem to use this key. So I am ok with merging this.

@dirk-thomas dirk-thomas merged commit a17eb2c into ros:master Jun 29, 2017
@k-okada k-okada deleted the fix_duplicates_pocketsphinx branch July 15, 2017 00:52
@k-okada k-okada mentioned this pull request Aug 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-okada @dirk-thomas @tfoote