PF detailed diff #2629
Merged
PF detailed diff #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
Closed
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
50fdce9 to
74c623e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
+ Coverage 69.39% 69.43% +0.04%
==========================================
Files 301 301
Lines 38560 38590 +30
==========================================
+ Hits 26759 26796 +37
+ Misses 10281 10270 -11
- Partials 1520 1524 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
b677d0f to
3d1d6b5
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
009000c to
da9413d
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
3d1d6b5 to
e2a772c
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
da9413d to
3dc7185
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
e2a772c to
cdb2b0f
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
2321542 to
03b445c
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
cdb2b0f to
b1a1cbf
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
03b445c to
eb3e316
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
b1a1cbf to
27b43ab
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
863540c to
d55566a
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
27b43ab to
906cb5a
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
d55566a to
638dc4f
Compare
VenelinMartinov
added a commit
that referenced
this pull request
Nov 20, 2024
This change adds additional testing for Diff in PF for sets involving Computed. The following schemas are covered: - Set block with a Computed attribute - Set block with a Computed attribute and RequiresReplace on the non-computed attribute - Set block with a Computed attribute and RequiresReplace on the computed attribute - Set block with a Computed attribute and RequiresReplace on the block - Set block with a Computed attribute and no UseStateForUnknown on the Computed attribute For each of these we test both when the Computed attribute is specified in the program and when it is not. For each of these schemas we test the full set of scenarios added in #2592 This should give us some confidence that the changes we are making by adding Detailed Diff for PF are good for Computed properties. I will categorize all the issues here as a follow-up before merging #2629
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
906cb5a to
f7fd6eb
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
fcc0655 to
529ed9e
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
f7fd6eb to
0dac56b
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
52bf5ef to
65bc464
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
0dac56b to
72c930a
Compare
VenelinMartinov
force-pushed
the
vvm/fix_provider_server_detailed_diff1
branch
from
f8aba52 to
12bb0f7
Compare
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
81b7e10 to
33e32f7
Compare
VenelinMartinov
added a commit
that referenced
this pull request
Nov 25, 2024
This change fixes an issue with the `provider_server` implementation's detailed diff handling. Previously passing a detailed diff to it would result in the previews being deleted. This is tested as part of #2629 The problem was that we were re-calculating the `diffs` and `replaces` keys for the GRPC Diff protocol in the `provider_server` implementation but also doing that incorrectly. Instead this change now makes `provider_server`'s `marshalDiff` just pass through the `diffs` and `replaces` which we have already calculated in https://github.com/pulumi/pulumi-terraform-bridge/blob/1d6b032f3e376af4667c6c4d80a65eff072df807/pkg/pf/tfbridge/provider_diff.go#L108-L109 fixes #2620
Base automatically changed from
vvm/fix_provider_server_detailed_diff1
to
master
November 25, 2024 15:23
This reverts commit 0b4ed87bba2f3158c383fe9557feb69c141ff04e.
This reverts commit 529ed9e.
VenelinMartinov
force-pushed
the
vvm/pf_detailed_diff1
branch
from
33e32f7 to
897bf79
Compare
VenelinMartinov
added a commit
that referenced
this pull request
Nov 26, 2024
This change adds recordings of the detailed diff sent to the engine to all Diff cross-tests in PF. This helps with spot-checking the results and troubleshooting issues. This comes after #2629 in order to reduce the noise in the change there.
|
This PR has been shipped in release v3.97.0. |
This was referenced Dec 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change integrates the detailed diff v2 algorithm for the Plugin Framework bridge. This leads to better previews for many common operations.
Will follow-up on #2660 as the only regression compared to not computing the detailed diff in the bridge.
fixes #752
fixes #2647
fixes #2649
fixes #2650