Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Diff cross-tests for sets with defaults #2640

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 19, 2024

This change adds cross-tests for PF sets with defaults. Similar to #2638 and #2639

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (bef446f) to head (356abe6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2640      +/-   ##
==========================================
- Coverage   69.97%   69.96%   -0.01%     
==========================================
  Files         367      367              
  Lines       44503    44503              
==========================================
- Hits        31140    31138       -2     
- Misses      11734    11737       +3     
+ Partials     1629     1628       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@VenelinMartinov VenelinMartinov force-pushed the pf-cross-tests-for-computed-set branch from a01b833 to 7ecd0a5 Compare November 20, 2024 14:09
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_cross_tests_for_sets_with_defaults branch from 2bd520a to 02d9ef9 Compare November 20, 2024 14:09
@VenelinMartinov VenelinMartinov changed the title PF cross-tests for sets with defaults PF Diff cross-tests for sets with defaults Nov 20, 2024
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@VenelinMartinov VenelinMartinov force-pushed the pf-cross-tests-for-computed-set branch from 7ecd0a5 to fd5a1e8 Compare November 20, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_cross_tests_for_sets_with_defaults branch from 02d9ef9 to 5fbeb0c Compare November 20, 2024 17:42
Base automatically changed from pf-cross-tests-for-computed-set to master November 20, 2024 19:17
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_cross_tests_for_sets_with_defaults branch from 5fbeb0c to 356abe6 Compare November 20, 2024 19:18
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 20, 2024 19:19
@VenelinMartinov VenelinMartinov merged commit d8838ae into master Nov 20, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_cross_tests_for_sets_with_defaults branch November 20, 2024 20:12
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.96.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants