Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF peviews do not show show default values in old config #2649

Closed
VenelinMartinov opened this issue Nov 21, 2024 · 2 comments · Fixed by #2629
Closed

PF peviews do not show show default values in old config #2649

VenelinMartinov opened this issue Nov 21, 2024 · 2 comments · Fixed by #2629
Assignees
Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Nov 21, 2024

When previewing a change in a resource using the Plugin Framework we incorrectly miss default values in old inputs

    ~ testprovider:index/test:Test: (update)
        [id=test-id]
        [urn=urn:pulumi:test::project::testprovider:index/test:Test::p]
      + key: {
          + nested: "value"
        }
Resources:
    ~ 1 to update
    1 unchanged

versus

  # testprovider_test.res will be updated in-place
  ~ resource "testprovider_test" "res" {
        id  = "test-id"
      ~ key = {
          ~ nested = "default" -> "value"
        }
    }

see TestDetailedDiffObject/attribute_default_no_replace/added

@VenelinMartinov VenelinMartinov added area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec labels Nov 21, 2024
@VenelinMartinov VenelinMartinov changed the title PF peviews do not show show default values in old config PF peviews do not show show default values Nov 21, 2024
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 21, 2024

cc @t0yv0 I think you suspected this before and have suggested it to me. I've added some tests to confirm this.

It's still a problem, PF does not apply defaults in check so the engine does not have access to the defaults. What is fixed here is that previously we would not show defaults in old values either.

@VenelinMartinov VenelinMartinov changed the title PF peviews do not show show default values PF peviews do not show show default values in old config Nov 22, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 25, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2629 and shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-framework Support for Plugin Framework based providers bug/diff Bugs in computing Diffs and planning resource changes kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants