Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defailed diff in pf #2602

Closed
wants to merge 37 commits into from
Closed

defailed diff in pf #2602

wants to merge 37 commits into from

Conversation

VenelinMartinov
Copy link
Contributor

No description provided.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 7, 2024

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (6d57a22) to head (a97cc06).

Files with missing lines Patch % Lines
pkg/pf/tfbridge/provider_diff.go 75.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           vvm/pf_diff_tests    #2602      +/-   ##
=====================================================
+ Coverage              60.99%   61.02%   +0.02%     
=====================================================
  Files                    389      389              
  Lines                  51939    51964      +25     
=====================================================
+ Hits                   31681    31711      +30     
+ Misses                 18458    18452       -6     
- Partials                1800     1801       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_detailed_diff branch 2 times, most recently from e956125 to 60c37b7 Compare November 7, 2024 17:52
Base automatically changed from vvm/pf_diff_tests to master November 14, 2024 12:07
@VenelinMartinov
Copy link
Contributor Author

superseded by #2629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant