-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Deprecate *Component
and *Props
props
#41281
Comments
@DiegoAndai Hi man, hope all is well! Can you mark speed dial as under way 40698. I'll be adding to it over the coming weeks 🤟 |
@harry-whorlow done 🙌🏼 |
Utils for the codemods of these deprecations were added in #41685. This makes implementing the codemods easier. |
@DiegoAndai I think I'll take up menu next, I'll create a pull request in the coming days. 🤟 |
My draft for menu, if you could mark menu as 'in progress' that would be awesome. 🤟 |
Hey everyone! With the core team, we've been discussing that composition might be a better API than slots for these props' use cases. It hasn't been decided yet if we will take this approach, but until we have more clarity, I'm marking this issue as on hold. For v6, we should revert the deprecation messages we've added. Is someone here interested in opening a PR for that? It should only revert the deprecation messages, not the code itself. Note that #41279 is not on hold. We will continue with that one, as having two names for the same thing ( I'm sorry if you had open PRs and this disappoints you 😓 but we should strive for the best API 🙌🏼 🚀. For the moment, let's close open PRs. I'll keep you updated. |
@DiegoAndai I could do this. |
@DiegoAndai greetings! I see there are more tickets being linked to this one lately. Perhaps this current issue has been given any more thoughts from the core team and there is some decision now (together with #37585) ? |
Part of #40417
Description
Deprecate
*Component
and*Props
props in v6, planned for removal in v7.slots
andslotProps
slots
orslotProps
props do not exist:Example PR
Contributing
Feel free to take any components that still need to be done or in progress. Please mention this issue in your PR so we can link it in the description and keep it up to date.
Components to migrate
ordered by page views
ButtonBaseSelect@siriwatknp (the current implementation does not allow to passslots, slotProps
to theSelectInput
)NativeSelect@siriwatknp (the current implementation does not allow to passslots, slotProps
to theSelectInput
)slots
andslotProps
. #44570 @siriwatknp*TypographyProps
and completeslots
,slotProps
#44729Search keywords: deprecation material-ui
The text was updated successfully, but these errors were encountered: