[TablePagination] Add the rest of slots and slotProps.
#44570
Conversation
Netlify deploy previewhttps://deploy-preview-44570--material-ui.netlify.app/ @material-ui/core: parsed: +0.11% , gzip: +0.09% Bundle size reportDetails of bundle changes (Toolpad) |
| /** | ||
| * @ignore | ||
| */ | ||
| className: PropTypes.string, |
There was a problem hiding this comment.
Yes, this is generated from the proptypes script.
There was a problem hiding this comment.
Right, I understand that. My question was, why in this PR related to adding slots, is the className being removed from the proptypes?
I see it was probably due to className being removed from the props destructuring here?
If so, that's ok. My only final question would be, if an user was providing className to this component, would this change make it throw a console warning?
There was a problem hiding this comment.
If so, that's ok. My only final question would be, if an user was providing className to this component, would this change make it throw a console warning?
No, it won't throw a warning. Tested with this sandbox.
packages/mui-codemod/src/deprecations/table-pagination-props/test-cases/actual.js
Outdated
Show resolved
Hide resolved
…ecation/table-pagination
github-actions
bot
added
the
PR: out-of-date
…ecation/table-pagination
github-actions
bot
removed
the
PR: out-of-date
Part of #41281
closes #43408 (see the fix)
root, toolbar, spacer, selectLabel, menuItem, displayedRowsto slots and slotProps.