[material-ui][StepContent] Add slots and slotProps #44742
Conversation
sai6855
added
component: stepper
Netlify deploy previewStepContent: parsed: +2.37% , gzip: +2.08% Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
@sai6855 I replied in #42157 (comment), but that's a special case. For TransitionComponent, lets deprecate as we did with the others: https://mui.com/material-ui/migration/migrating-from-deprecated-apis/#transitioncomponent
Besides that, the PR is good 👍🏼 but please let's deprecate in the same PR.
In cases you shown above, |
|
@sai6855 thanks for checking. I still think we should go forward with the deprecation, as:
Again, thanks for checking first. I think it won't be a problem, but if users have issues, we can remove/change the deprecation in the future. |
There was a problem hiding this comment.
Hey @sai6855, sorry for not being clearer before: I only meant we should add the deprecation, not change how TransitionComponent is handled, see the comment below.
This is so change happens only when migrating to slots, and not when upgrading to a new version. Does that make sense?
| @@ -110,9 +110,7 @@ const StepContent = React.forwardRef(function StepContent(inProps, ref) { | |||
| ownerState={ownerState} | |||
| {...other} | |||
| > | |||
| <TransitionSlot as={TransitionComponent} {...transitionProps}> | |||
There was a problem hiding this comment.
Lets revert this change, TransitionComponent should still be passed through as
There was a problem hiding this comment.
Opps! as prop somehow got lost, added it back here 3dc1b68
| @@ -83,24 +86,33 @@ const StepContent = React.forwardRef(function StepContent(inProps, ref) { | |||
| transitionDuration = undefined; | |||
| } | |||
|
|
|||
| const externalForwardedProps = { | |||
| slots: { transition: TransitionComponent, ...slots }, | |||
There was a problem hiding this comment.
This should be:
| slots: { transition: TransitionComponent, ...slots }, | |
| slots, |
As TransitionComponent is being passed through as
Co-authored-by: Diego Andai <[email protected]> Signed-off-by: sai chand <[email protected]>
Part of #41281
This PR adds
slotsandslotPropsand deprecatesTransitionComponentandTransitionProps