[material-ui][Tooltip] deprecate *Component and *Props for v6
#42120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewSpeedDialAction: parsed: +0.77% , gzip: +0.77% Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
zannager
added
the
component: tooltip
34 tasks
|
CI fails because apparently the same popper element is not used in a rerender. I think that the error is in the useSlot hook. However, I have not found it yet. If anyone has an idea please let me know. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Hey @lhilgert9! thanks for working on this. Please see #41281 (comment). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41281.
@DiegoAndai
Question:
Is it important that className of PopperProps and slotProps.popper are both applied, because a test exists in Tooltip.test.js?
I've also seen that #42107 is being worked on. We should see that the changes in these two PR's go together.