[material-ui][TextField] InputProps vs inputProps confusion

[eyn]

The TextField (nor Input) does not pass the step property through to the input as a step attribute.

• I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

<Textfield type="number" step="0.01" /> renders a <input type="number" step="0.01" />

Current Behavior

<Textfield type="number" step="0.01" /> renders a <input type="number" />

Steps to Reproduce (for bugs)

1. Go to https://codesandbox.io/s/lyxw254vz9
2. Click on the up/down arrows on right of textbox and see differences in behaviour

Context

Your Environment

Tech	Version
Material-UI	1.0.0.rc0
React	16
browser	Safari - Not possible to insert 0.xx number and pass validation. Chrome accepts 0.xx number and validates it but step is still by unit

[eyn]

Happy to do a pr for this if you're happy having step added to TextField (and Input)?

[sakulstra]

didn't test, but I guess you should use <TextField inputProps={{step: 0.01}} /> instead? It#s a prop on Input instead of TextField.

update: sry, just checked your sandbox :D you already came up with that. What#s the problem with the inputProps solution? I guess there are more props we don't pass down automagically: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement so it might be consistent to not do it at all.

[oliviertassinari]

@eyn We try to find a tradeoff between the popular properties applied on the input and the bundle size of the component. step hasn't made it yet.

[oliviertassinari]

I have added the waiting for users upvotes tag. I'm closing the issue as I'm not sure people are looking for such abstraction. So please upvote this issue if you are. We will prioritize our effort based on the number of upvotes.

[eyn]

Agree it's a balance and step probably falls outside that line at the moment. Just wanted at least a discussion. Any thoughts about a helpful message in development mode for properties that are valid on <input /> but not passed on by TextField or Input.

[oliviertassinari]

Any thoughts about a helpful message in development mode for properties that are valid on but not passed on by TextField or Input.

@eyn I think that it's a good idea 👍

[leMaik]

So… Is there actually no way to specify the steps attribute? 😞

[oliviertassinari]

@leMaik You can with the inputProps property: https://codesandbox.io/s/lyxw254vz9

<TextField inputProps={{ step: "0.01" }} type="number" />

[oliviertassinari]

I think that @eyn's idea is brilliant. We could add warnings about this issue at runtime so people don't have to find this issue on GitHub.

[leMaik]

@oliviertassinari Oh, with a small i. 😓 A warning would have helped me a lot, indeed. I'll look into adding them later. 👍

[sakulstra]

we've been running into this problem over and over again(with min/max/step) :D and eventually ended up writing a custom NumberField which deflattens these props. Would it make sense to expose such a component within material-ui?