Disable console-eager-eval and Live Expressions panel #164
+65
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a mitigation for S523384, affecting builds of react-native-devtools-frontend shipped React Native 0.78 and onwards. Unfortunately, Hermes doesn't yet correctly implement CDP's `Runtime.evaluate#throwOnSideEffect`, and so we cannot safely use eager evaluation. Currently, this can cause erratic console behaviour while typing.
huntie
force-pushed
the
S523384-mitigation
branch
from
f0e5922 to
1280e5f
Compare
huntie
added a commit
to huntie/rn-chrome-devtools-frontend
that referenced
this pull request
May 23, 2025
2 tasks
huntie
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a mitigation for S523384, affecting builds of react-native-devtools-frontend shipped React Native 0.78 and onwards.
Unfortunately, Hermes doesn't yet correctly implement CDP's
Runtime.evaluate#throwOnSideEffect, and so we cannot safely use eager evaluation. Currently, this can cause erratic and unsafe console behaviour while typing.🚧 We intend to restore this feature when we can, but it will require a future Hermes release.
Test plan
Before
After
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.